Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39356, zipfile: Remove code handling DeprecationWarning #18027
+9
−19
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
At this commit, the _struct.pack() function emitted DeprecatedWarning when getting a float whereas an integer is expected. These warnings have been removed by commit ea835e7. It's now an hard error. Example: So "except DeprecationWarning:" is no longer needed in zipfile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedJan 16, 2020
•
edited by bedevere-bot
Remove old "except DeprecationWarning:" code path added by
commit bf02e3b. It's no longer
needed.
https://bugs.python.org/issue39356