Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] bpo-34575: Build with only VS2015 on AppVeyor #9066

Merged
merged 3 commits into from Sep 5, 2018
Merged

[3.6] bpo-34575: Build with only VS2015 on AppVeyor #9066

merged 3 commits into from Sep 5, 2018
+0 −1

Conversation

@zware
Copy link
Member

zware commented Sep 4, 2018 •
edited by bedevere-bot

https://bugs.python.org/issue34575
@zware
[DO NOT MERGE] Test AppVeyor with only VS2017
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fdbf928
@zware zware added the DO-NOT-MERGE label Sep 4, 2018
zware added 2 commits Sep 4, 2018
@zware
Update appveyor.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7fbb425
@zware
Remove VS2017 image from AppVeyor config
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2ccab99 
We're currently having caching issues between the two images, and VS2017 builds are tested by VSTS.  Removing that one here will significantly decrease the time that AppVeyor builds take on this branch.
@zware zware changed the title [DO NOT MERGE] Test AppVeyor with only VS2017 [3.6] Build with only VS2015 on AppVeyor Sep 5, 2018
@zware zware changed the title [3.6] Build with only VS2015 on AppVeyor [3.6] bpo-34575: Build with only VS2015 on AppVeyor Sep 5, 2018
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Sep 5, 2018

"bedevere/issue-number — No issue # in title or "skip issue" label found" stupid bot
@vstinner
vstinner approved these changes Sep 5, 2018
View changes
Copy link
Member

vstinner left a comment

LGTM.

According to @zware there is a VS2017 buildbot, so I don't think that it matters to check VS2017 as pre-commit. This change should make AppVeyor twice faster on 3.6 which is a good thing, since AppVeyor is currently the slowest pre-commit CI on PRs.
@zware zware changed the title [3.6] bpo-34575: Build with only VS2015 on AppVeyor bpo-34575: [3.6] Build with only VS2015 on AppVeyor Sep 5, 2018
@zware zware changed the title bpo-34575: [3.6] Build with only VS2015 on AppVeyor [3.6] bpo-34575: Build with only VS2015 on AppVeyor Sep 5, 2018
@zware zware merged commit 635461f into python:3.6 Sep 5, 2018
9 checks passed
9 checks passed
Linux-PR #Linux-PR_20180905.13 succeeded
Details
Windows-PR #Windows-PR_20180905.13 succeeded
Details
bedevere/issue-number Issue number 34575 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docs #docs_20180905.13 succeeded
Details
macOS-PR #macOS-PR_20180905.13 succeeded
Details
@zware zware deleted the zware:appveyor-test branch Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@zware @vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.