bpo-27593: Get SCM build info from git instead of hg #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on commit 5c4b0d0 by Ned Deily, which is based on original patches by Brett Cannon and Steve Dower. Remove also the private _Py_svnversion() function and SVNVERSION variable. Note: Py_SubversionRevision() and Py_SubversionShortBranch() are unchanged, they are part of the public API.
vstinner
commented
Apr 27, 2017
| @@ -134,6 +134,10 @@ Documentation | |||
| Build | |||
| ----- | |||
|
|
|||
| - bpo-27593: sys.version and the platform module python_build(), | |||
There was a problem hiding this comment.
Hum, I copied the news item from master, but I forgot to update it.
brettcannon
approved these changes
Apr 28, 2017
|
Ok, merged. Thanks for the review @brettcannon ! |
markbt
added a commit
to dgrunwald/rust-cpython
that referenced
this pull request
Feb 12, 2018
Upstream python removed `_Py_svnversion`, `_Py_hgversion` and `_Py_hgidentifier` in python/cpython#1327, replacing them with `_Py_gitversion` and `_Py_gitidentifier`. These are private symbols which shouldn't be exposed here anyway, so just remove them.
markbt
added a commit
to dgrunwald/rust-cpython
that referenced
this pull request
Feb 13, 2018
Upstream python removed `_Py_svnversion`, `_Py_hgversion` and `_Py_hgidentifier` in python/cpython#1327, replacing them with `_Py_gitversion` and `_Py_gitidentifier`. These are private symbols which shouldn't be exposed here anyway, so just remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on commit 5c4b0d0 by Ned
Deily, which is based on original patches by Brett Cannon and Steve
Dower.
Remove also the private _Py_svnversion() function and SVNVERSION
variable.
Note: Py_SubversionRevision() and Py_SubversionShortBranch() are
unchanged, they are part of the public API.