Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) #14772

Merged
merged 2 commits into from Sep 7, 2019
Merged

[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) #14772

merged 2 commits into from Sep 7, 2019

Conversation

@vstinner
Copy link
Member

vstinner commented Jul 14, 2019 •
edited by bedevere-bot

(cherry picked from commit 8d0ef0b)

Co-authored-by: Steve Dower steve.dower@python.org
(cherry picked from commit fd1771d)

https://bugs.python.org/issue36742
@miss-islington @vstinner
bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812)…
Loading status checks…
5e3ced9 
… (GH-13814)

(cherry picked from commit 8d0ef0b)

Co-authored-by: Steve Dower <steve.dower@python.org>
(cherry picked from commit fd1771d)
@vstinner vstinner changed the title bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) [3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) Jul 14, 2019
@vstinner vstinner removed the type-security label Jul 14, 2019
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jul 14, 2019

https://bugs.python.org/issue36742 is not fully fixed in the 3.5 branch: commit 4655d57 wasn't enough. We also need this second fix which is a backport from Python 3.6.
@vstinner vstinner requested a review from zooba Jul 14, 2019
@larryhastings

This comment has been minimized.

Sign in to view
Copy link
Contributor

larryhastings commented Jul 14, 2019

Just to confirm: this PR doesn't change any code in the standard library. It only changes tests. That's what you wanted?
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jul 14, 2019

It changes the urllib module. I backported the change, I didn't make any change.
@larryhastings
Merge branch '3.5' into urlnorm35
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
22ff021
@larryhastings larryhastings merged commit 095373c into python:3.5 Sep 7, 2019
5 checks passed
5 checks passed
bedevere/issue-number Issue number 36742 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Sep 7, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!
@larryhastings

This comment has been minimized.

Sign in to view
Copy link
Contributor

larryhastings commented Sep 7, 2019

Thanks for the 3.5 backport love!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@vstinner @larryhastings @bedevere-bot @the-knights-who-say-ni @miss-islington
You can’t perform that action at this time.