Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upremove unused __version__ from mock.py #17977
Conversation
This isn't included in `__all__` and could be a source of confusion.
This comment has been minimized.
This comment has been minimized.
@tirkarthi / @mariocj89 - can you see any problems with this? |
This comment has been minimized.
This comment has been minimized.
My username in GitHub is @tirkarthi :) Regarding the
|
This comment has been minimized.
This comment has been minimized.
Cool, I'm comfortable removing this as you're +0. It's now confusing because it clashes with the version that the backport needs to have for sensible release to pypi. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 13, 2020
@cjw296: Please replace |
remove unused __version__ from mock.py (python#17977)
This isn't included in `__all__` and could be a source of confusion.
This isn't included in `__all__` and could be a source of confusion.
This isn't included in `__all__` and could be a source of confusion.
cjw296 commentedJan 13, 2020
This isn't included in
__all__
and could be a source of confusion.