Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine snprintf only for msvc #17981

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@jschueller
Copy link

jschueller commented Jan 13, 2020

This should only be enabled specifically for visual studio compiler,
not all windows platforms
(msvc<14 actually, see also https://bugs.python.org/issue36020)

Fixes build with MinGW

This should only be enabled specifically for visual studio compiler,
not all windows platforms
(msvc<14 actually, see also https://bugs.python.org/issue36020)

Fixes build with MinGW
@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Jan 13, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jschueller

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.