Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.8] Fix typo in multiprocessing.pool.AsyncResult.successful doc. (GH-17932) #18015
+1
−1
Conversation
Since 3.7 `successful` raises a `ValueError` as explained in the next text block from the documentation: _Changed in version 3.7: If the result is not ready, ValueError is raised instead of AssertionError._ No issue associated with this PR. Should be backported in 3.7 and 3.8. (cherry picked from commit dc0284e) Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
@awecx: Status check is done, and it's a success |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
miss-islington commentedJan 15, 2020
•
edited
Since 3.7
successfulraises aValueErroras explained in the next text block from the documentation:Changed in version 3.7: If the result is not ready, ValueError is raised instead of AssertionError.
No issue associated with this PR.
Should be backported in 3.7 and 3.8.
(cherry picked from commit dc0284e)
Co-authored-by: Antoine 43954001+awecx@users.noreply.github.com
Automerge-Triggered-By: @pitrou