Skip to content

bpo-28879: Add Date header if missing in smtplib send_message #5176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bpo-28879: Add Date header if missing in smtplib send_message #5176

wants to merge 1 commit into from

Conversation

elafontaine
Copy link

@elafontaine elafontaine commented Jan 13, 2018 •
edited by bedevere-bot
Loading

@elafontaine elafontaine requested a review from a team as a code owner January 13, 2018 23:15
@elafontaine elafontaine force-pushed the bpo-28879 branch 2 times, most recently from 1268586 to 5434c2c Compare January 13, 2018 23:33
@elafontaine
Copy link
Author

elafontaine commented Jan 13, 2018 •
edited
Loading

@bitdancer I've remade the PR for this BPO as the other one was messy. I hope this will help accelerate the approval process :).

Regards,
Eric Lafontaine

matrixise
matrixise requested changes Jan 30, 2018
View reviewed changes
@elafontaine
Copy link
Author

elafontaine commented Aug 1, 2018 •
edited
Loading

Still awaiting... Could we get a different approver if he's busy?

@brettcannon brettcannon added the type-feature A feature request or enhancement label Apr 17, 2019
@csabella csabella requested a review from maxking November 16, 2019 01:39
@csabella csabella requested review from bitdancer and maxking and removed request for maxking January 11, 2020 00:21
maxking
maxking suggested changes Jan 12, 2020
View reviewed changes
Copy link
Contributor

@maxking maxking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elafontaine for the patch, I have some minor documentation comments but otherwise it LGTM!

Can you please also fix the merge conflict in the PR, perhaps rebase?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@elafontaine
Copy link
Author

elafontaine commented Jan 13, 2020 via email

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@elafontaine

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@elafontaine
Copy link
Author

Sorry for bringing back an old issue :) but thanks for looking at merging this

@elafontaine
Copy link
Author

Sorry, folks, I don't have my linux machine... will have to use the CI...

@csabella
Copy link
Contributor

@elafontaine, please resolve the merge conflicts. Once you've done that, please add the message I have made the requested changes; please review again for this to get routed back to maxking for review. Thank you!

@elafontaine
Copy link
Author

elafontaine commented May 28, 2020 •
edited
Loading

@csabella I had a problem in the test which I have resolved. I'm however not sure due to the nature of format if this will be supported everywhere.

I also rebased my branch on top. I'm hoping this should resolve any technical issue I had :). Let me know if it's good to proceed or not.

@elafontaine
Copy link
Author

Someone can help me understand what the error is for this message ;

Fixing Python file whitespace ... 1 file:
  Lib/test/test_smtplib.py

From the travis-ci the python tests reports a failure on linting... but if I ask my IDE, it formats 42 lines (and doesn't touch mines...). I run on Windows so doesn't have a setup with make... :(.

@elafontaine elafontaine force-pushed the bpo-28879 branch 2 times, most recently from 81cf789 to d2fb65e Compare May 28, 2020 01:57
@elafontaine
Copy link
Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@maxking, @matrixise: please review the changes made to this pull request.

@elafontaine
Copy link
Author

I see that 2 changes are requested. Could I know how to resolve them or does it has to be done by the maintainers?

@elafontaine
Copy link
Author

Anyone can help get this through ?

@elafontaine
Copy link
Author

@rhettinger sorry to ask you directly, but who would be best placed to review and help ?

(so sorry, you're my teacher/mentor through youtube, so I feel really bad asking...)

@rhettinger rhettinger requested review from warsaw and ambv April 30, 2022 23:05
@HenningvonBargen HenningvonBargen mannequin mentioned this pull request May 21, 2022
Open
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitdancer bitdancer Awaiting requested review from bitdancer

@maxking maxking Awaiting requested review from maxking

@matrixise matrixise Awaiting requested review from matrixise

@warsaw warsaw Awaiting requested review from warsaw

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
awaiting change review stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@elafontaine @bedevere-bot @the-knights-who-say-ni @csabella @matrixise @maxking @brettcannon @ezio-melotti