bpo-39299: Add more tests for mimetypes and its cli. #17949

tirkarthi · 2020-01-11T06:07:14Z

Add test for case insensitive check of types and extensions.
Add test for data url with no comma.
Add test for read_mime_types.
Add tests for the mimetypes cli.

https://bugs.python.org/issue39299


        Add more tests for mimetypes and its cli.

tirkarthi · 2020-01-11T07:03:13Z

Ah, the logic to load the initial database is with known types, common types and the list of files from mimetypes.knownfiles subsequently overriding each other. At the start of the test mimetypes.knownfiles is set as empty list but since I am using script_helper.assert_python_ok setting the list of knownfiles to empty list doesn't work and mac seems to load a mimetype for .pic that is different from common types and overrides it.

I guess my tests can be rewritten to make sure the tests are not machine dependent based on the files.


        Refactor test setup and main call for mimetypes.

* Set knownfiles for mimetypes to be empty list only during setup so that it doesn't leak into other tests. * Move the __main__ code to separate function for better testing.

tirkarthi · 2020-01-11T08:11:43Z

I have moved the code for __main__ to be a private function to help testing by directly calling it instead of using subprocess to invoke python -m mimetypes. I have also found that mimetypes.knownfiles was set as empty at the top of the module. It has a potential side effect that all other tests that follow after test_mimetypes will also have empty list of files when accessing mimetypes.knownfiles. I have moved it to setup call so that this change doesn't affect other tests.


        Inherit from mixin. Set _db as None to test initialization.


        Revert _db to be None in setup.


        Use Mixin for Windows test as well.


        Remove setting inited and default initialization since they are done …

…at module import.

tirkarthi · 2020-01-11T14:10:58Z

I am slightly confused since importing mimetypes itself sets inited as False and also calls _default_mime_types to set global values so I removed them from the test since it's already done. In the test when I call the _default_mime_types which sets the global variables the value for suffix, encoding and types maps it poses a strange failure for windows test which copies the types_map and clears it to reinitialize it again where _types_map[True] is empty. I need to figure out yet over why the call has a side effect.


        Revert the mixin changes and stick to tests.


        Use tearDownModule to restore knownfiles.

tirkarthi · 2020-01-11T16:58:28Z

I resorted to using setUpModule and tearDownModule to have the original test code and not to use mixins for the setup. This will restore knownfiles value in the end. The test coverage with this PR stands at 80% with the code for windows not as part of the coverage report.

maxking

LGTM! Thanks @tirkarthi


        Merge pull request #174 from python/master

bpo-39299: Add more tests for mimetypes and its cli. (pythonGH-17949)

tirkarthi · 2020-01-13T16:24:19Z

Thanks @maxking and @asvetlov for the review. I would like to backport this PR to 3.8 and 3.7. It moves code under __main__ to _main but could help in catching regressions if any. Thoughts?

asvetlov · 2020-01-13T18:20:13Z

The change is safe to backport; please feel free to do it if you want.
Start from adding needs backport to xx labels here, the bot does the rest and commits the backport after approval if everything goes smoothly.

tirkarthi · 2020-01-13T18:24:45Z

Thanks Andrew, I will add the labels and wait for the CI.

miss-islington · 2020-01-13T18:25:08Z

Thanks @tirkarthi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington · 2020-01-13T18:25:09Z

Thanks @tirkarthi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖


        bpo-39299: Add more tests for mimetypes and its cli. (pythonGH-17949)

* Add tests for case insensitive check of types and extensions as fallback. * Add tests for data url with no comma. * Add tests for read_mime_types. * Add tests for the mimetypes cli and refactor __main__ code to private function. * Restore mimetypes.knownfiles value at the end of the test. (cherry picked from commit d8efc14) Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>

bedevere-bot · 2020-01-13T18:25:22Z

GH-17991 is a backport of this pull request to the 3.7 branch.


        bpo-39299: Add more tests for mimetypes and its cli. (pythonGH-17949)

* Add tests for case insensitive check of types and extensions as fallback. * Add tests for data url with no comma. * Add tests for read_mime_types. * Add tests for the mimetypes cli and refactor __main__ code to private function. * Restore mimetypes.knownfiles value at the end of the test. (cherry picked from commit d8efc14) Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>

bedevere-bot · 2020-01-13T18:25:29Z

GH-17992 is a backport of this pull request to the 3.8 branch.


        bpo-39299: Add more tests for mimetypes and its cli. (pythonGH-17949)

* Add tests for case insensitive check of types and extensions as fallback. * Add tests for data url with no comma. * Add tests for read_mime_types. * Add tests for the mimetypes cli and refactor __main__ code to private function. * Restore mimetypes.knownfiles value at the end of the test.


        bpo-39299: Add more tests for mimetypes and its cli. (pythonGH-17949)

* Add tests for case insensitive check of types and extensions as fallback. * Add tests for data url with no comma. * Add tests for read_mime_types. * Add tests for the mimetypes cli and refactor __main__ code to private function. * Restore mimetypes.knownfiles value at the end of the test.


        bpo-39299: Add more tests for mimetypes and its cli. (pythonGH-17949)

* Add tests for case insensitive check of types and extensions as fallback. * Add tests for data url with no comma. * Add tests for read_mime_types. * Add tests for the mimetypes cli and refactor __main__ code to private function. * Restore mimetypes.knownfiles value at the end of the test.

Add more tests for mimetypes and its cli.

Loading status checks…

eddcf84

tirkarthi added type-tests skip news labels Jan 11, 2020

tirkarthi requested a review from python/email-team as a code owner Jan 11, 2020

the-knights-who-say-ni added the CLA signed label Jan 11, 2020

bedevere-bot added the awaiting core review label Jan 11, 2020

Refactor test setup and main call for mimetypes.

Loading status checks…

a572c09

* Set knownfiles for mimetypes to be empty list only during setup so that it doesn't leak into other tests. * Move the __main__ code to separate function for better testing.

tirkarthi added 4 commits Jan 11, 2020

Inherit from mixin. Set _db as None to test initialization.

Loading status checks…

7fc4346

Revert _db to be None in setup.

Loading status checks…

58a7632

Use Mixin for Windows test as well.

Loading status checks…

fa3d3a2

Remove setting inited and default initialization since they are done …

Loading status checks…

2261488

…at module import.

tirkarthi added 2 commits Jan 11, 2020

Revert the mixin changes and stick to tests.

28928c8

Use tearDownModule to restore knownfiles.

Loading status checks…

b80c9c3

maxking approved these changes Jan 12, 2020

View changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jan 12, 2020

asvetlov approved these changes Jan 12, 2020

View changes

tirkarthi deleted the tirkarthi:test-cases-mimetypes branch Jan 13, 2020

bedevere-bot removed the awaiting merge label Jan 13, 2020

tirkarthi added the needs backport to 3.7 label Jan 13, 2020

tirkarthi added the needs backport to 3.8 label Jan 13, 2020

bedevere-bot removed the needs backport to 3.7 label Jan 13, 2020

bedevere-bot removed the needs backport to 3.8 label Jan 13, 2020

python / cpython

bpo-39299: Add more tests for mimetypes and its cli. #17949

bpo-39299: Add more tests for mimetypes and its cli. #17949

tirkarthi commented Jan 11, 2020 •

edited by bedevere-bot

This comment has been minimized.

tirkarthi commented Jan 11, 2020

This comment has been minimized.

tirkarthi commented Jan 11, 2020

This comment has been minimized.

tirkarthi commented Jan 11, 2020

This comment has been minimized.

tirkarthi commented Jan 11, 2020

maxking left a comment

This comment has been minimized.

tirkarthi commented Jan 13, 2020

This comment has been minimized.

asvetlov commented Jan 13, 2020

This comment has been minimized.

tirkarthi commented Jan 13, 2020

This comment has been minimized.

miss-islington commented Jan 13, 2020

This comment has been minimized.

miss-islington commented Jan 13, 2020

This comment has been minimized.

bedevere-bot commented Jan 13, 2020

This comment has been minimized.

bedevere-bot commented Jan 13, 2020

python / cpython

Sponsor python/cpython

Join GitHub today

bpo-39299: Add more tests for mimetypes and its cli. #17949

bpo-39299: Add more tests for mimetypes and its cli. #17949

Conversation

tirkarthi commented Jan 11, 2020 • edited by bedevere-bot

This comment has been minimized.

tirkarthi commented Jan 11, 2020

This comment has been minimized.

tirkarthi commented Jan 11, 2020

This comment has been minimized.

tirkarthi commented Jan 11, 2020

This comment has been minimized.

tirkarthi commented Jan 11, 2020

maxking left a comment

This comment has been minimized.

tirkarthi commented Jan 13, 2020

This comment has been minimized.

asvetlov commented Jan 13, 2020

This comment has been minimized.

tirkarthi commented Jan 13, 2020

This comment has been minimized.

miss-islington commented Jan 13, 2020

This comment has been minimized.

miss-islington commented Jan 13, 2020

This comment has been minimized.

bedevere-bot commented Jan 13, 2020

This comment has been minimized.

bedevere-bot commented Jan 13, 2020

tirkarthi commented Jan 11, 2020 •

edited by bedevere-bot