Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39353: Deprecate the binhex module #18025

Open
wants to merge 2 commits into
base: master
from
Open

bpo-39353: Deprecate the binhex module #18025

wants to merge 2 commits into from
+120 −25

Conversation

@vstinner
Copy link
Member

vstinner commented Jan 16, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39353
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 16, 2020

cc @tiran
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 17, 2020

@serhiy-storchaka: Does you expect any issue just by marking the module as deprecated in 3.9?
@serhiy-storchaka

This comment has been minimized.

Sign in to view
Copy link
Member

serhiy-storchaka commented Jan 17, 2020

What is a benefit of deprecating it?

This module is a high-level interface to several functions in the binascii module. This is all macOS specific stuff, so you need to ask macOS experts. If this encoding no longer used in macOS, its support can be removed, with deprecating first. If there are no plans to remove, there is no reason to deprecate.
@serhiy-storchaka

This comment has been minimized.

Sign in to view
Copy link
Member

serhiy-storchaka commented Jan 17, 2020

If deprecate the binhex module, I think that it would be better to deprecate corresponding functions in the binascii module in the same issue and PR, so it will be easier to find the original discussion.
@vstinner
bpo-39353: Deprecate the binhex module
751e65a
@vstinner vstinner force-pushed the vstinner:deprecate_binhex branch from 1a8adf3 to bbbdc5c Jan 17, 2020
@vstinner
Deprecate binhex4 and hexbin4 standards
Loading status checks…
09f5a4c 
Deprecate binascii functions:

* b2a_hqx(), a2b_hqx()
* rlecode_hqx(), rledecode_hqx()
* crc_hqx()
@vstinner vstinner force-pushed the vstinner:deprecate_binhex branch from f99007d to 09f5a4c Jan 17, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 17, 2020

If deprecate the binhex module, I think that it would be better to deprecate corresponding functions in the binascii module in the same issue and PR, so it will be easier to find the original discussion.

Ok. Let's do that. I added a second commit which deprecates the 5 related functions of the binascii module.

I'm not sure about the binhex code to avoid emitting warnings on calls to deprecated binascii functions: with _ignore_deprecation_warning():. Is it useful to bother with that?

What is a benefit of deprecating it?

Let me answer on the issue instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed OS-mac awaiting core review
Projects
None yet
Milestone
No milestone
4 participants
@vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.