Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39156: Break up COMPARE_OP into four logically distinct opcodes. #17754
Conversation
3f4e3d4
to
2ee4c16
I have some minor comments. |
Doc/library/dis.rst
Outdated
@@ -961,6 +975,13 @@ All of the following opcodes use their arguments. | |||
|
|||
.. versionadded:: 3.1 | |||
|
|||
.. opcode:: JUMP_IF_NOT_EXC_MATCH (target) | |||
|
|||
Tests whether the second value on the stack is an exception matching TOS, and jumps if it is not. |
This comment has been minimized.
This comment has been minimized.
Python/ceval.c
Outdated
PyObject *left = POP(); | ||
if (PyTuple_Check(right)) { | ||
Py_ssize_t i, length; | ||
length = PyTuple_Size(right); |
This comment has been minimized.
This comment has been minimized.
Python/ceval.c
Outdated
if (PyTuple_Check(right)) { | ||
Py_ssize_t i, length; | ||
length = PyTuple_Size(right); | ||
for (i = 0; i < length; i += 1) { |
This comment has been minimized.
This comment has been minimized.
int res = PyErr_GivenExceptionMatches(left, right); | ||
Py_DECREF(left); | ||
Py_DECREF(right); | ||
if (res > 0) { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3e24674
to
8dbef33
8dbef33
to
1486559
8f56c51
to
449cb17
449cb17
to
5c9a327
9af0e47
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
…ythonGH-17754) Break up COMPARE_OP into four logically distinct opcodes: * COMPARE_OP for rich comparisons * IS_OP for 'is' and 'is not' tests * CONTAINS_OP for 'in' and 'is not' tests * JUMP_IF_NOT_EXC_MATCH for checking exceptions in 'try-except' statements.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
…ythonGH-17754) Break up COMPARE_OP into four logically distinct opcodes: * COMPARE_OP for rich comparisons * IS_OP for 'is' and 'is not' tests * CONTAINS_OP for 'in' and 'is not' tests * JUMP_IF_NOT_EXC_MATCH for checking exceptions in 'try-except' statements.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
…ythonGH-17754) Break up COMPARE_OP into four logically distinct opcodes: * COMPARE_OP for rich comparisons * IS_OP for 'is' and 'is not' tests * CONTAINS_OP for 'in' and 'is not' tests * JUMP_IF_NOT_EXC_MATCH for checking exceptions in 'try-except' statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
markshannon commentedDec 30, 2019
•
edited by bedevere-bot
Breaks up COMPARE_OP into four logically distinct opcodes:
This improves the clarity of the interpreter and should provide a modest speedup.
https://bugs.python.org/issue39156