Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39323: Fix directory separator of imghdr cli output #17993
+53
−2
Conversation
|
LGTM for test code :) and I left a comment on Lib/imghdr.py |
| @@ -148,7 +148,7 @@ def testall(list, recursive, toplevel): | |||
| import os | |||
| for filename in list: | |||
| if os.path.isdir(filename): | |||
| print(filename + '/:', end=' ') | |||
| print(filename + os.sep +':', end=' ') | |||
This comment has been minimized.
This comment has been minimized.
corona10
Jan 14, 2020
Member
I don't know this kind of code churn is proper,
But if this is needed, what about this?
print(f'{filename}{os.sep}:', end=' ')
This comment has been minimized.
This comment has been minimized.
tirkarthi
Jan 14, 2020
Author
Contributor
As a personal opinion, I don't see much improvement here in changing. It's just concatenating two separate variables and there are no other strings also as part of string like a + " equals " + b to f"{a} equals {b}" .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tirkarthi commentedJan 13, 2020
•
edited by bedevere-bot
os.septo indicate directory separator in imghdr cli output.https://bugs.python.org/issue39323