Skip to content

[BPO-30924] [BPO-30925] doc-files separate line and additional files patches #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[BPO-30924] [BPO-30925] doc-files separate line and additional files patches #591

wants to merge 2 commits into from

Conversation

warthog9
Copy link

@warthog9 warthog9 commented Mar 10, 2017 •
edited
Loading

doc-files Breakup should break files up into multiple lines, as per RPM expectation

when using %doc section of the RPM spec, it expects multiple files
to be listed each on their own line. Currently what gets passed in
is:

%doc file1 file2 file3

which throws:
error: More than one file on a line: file1
error: More than one file on a line: file2
error: More than one file on a line: file3

This breaks the files up into seperate lines:

%doc
file1
file2
file3

which works as expected with multiple files

Signed-off-by: John 'Warthog9' Hawley jhawley@vmware.com
Signed-off-by: John 'Warthog9' Hawley warthog9@eaglescrag.net

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement. The "bugs.python.org username " requested by the form is the "Login name" field under "Your Details".
  4. If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@mention-bot
Copy link

@warthog9, thanks for your PR! By analyzing the history of the files in this pull request, we identified @collinw, @loewis, @akuchling, @nnorwitz and @Yhg1s to be potential reviewers.

warthog9 added 2 commits March 14, 2017 14:06
@warthog9
doc-files should break files up into multiple lines, as per RPM expec…
8a9a731 
…tation

when using %doc section of the RPM spec, it expects multiple files
to be listed each on their own line.  Currently what gets passed in
is:

%doc file1 file2 file3

which throws:
	error: More than one file on a line: file1
	error: More than one file on a line: file2
	error: More than one file on a line: file3

This breaks the files up into seperate lines:

%doc
file1
file2
file3

which works as expected with multiple files

Signed-off-by: John 'Warthog9' Hawley <jhawley@vmware.com>
Signed-off-by: John 'Warthog9' Hawley <warthog9@eaglescrag.net>
@warthog9
Duplicate doc-files functionality, to inject files into bdist_rpm
69a5a94 
This duplicates the existing functionality from doc-files, however
it includes the files in the %files section as opposed to the %docs
section of the RPM

Signed-off-by: John 'Warthog9' Hawley <jhawley@vmware.com>
Signed-off-by: John 'Warthog9' Hawley <warthog9@eaglescrag.net>
@kushaldas
Copy link
Member

Few things are missing:

  • A bug in bugs.python.org
  • Update the title of the PR based on that
  • A test case for the same
  • Docs update to reflect this change

@warthog9 warthog9 changed the title doc-files should break files up into multiple lines, as per RPM expec… [BPO-30924] [BPO-30925] doc-files separate line and additional files patches Jul 13, 2017
@flavianh
Copy link

@kushaldas No activity for a long time, could someone close it?

@csabella
Copy link
Contributor

@warthog9 Please address the code review and leave a comment when this is ready for review again. If you are no longer interested in this pull request, feel free to close it. Thank you!

@nightlark
Copy link
Contributor

Should this be closed, given distutils is being deprecated according to https://bugs.python.org/issue30925#msg386350?

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@hugovk
Copy link
Member

hugovk commented Feb 19, 2022

Yes, let's close this, the related BPO issues have also been closed. But thank you for your contribution!

BPO-30924:

Should this be closed?

Copy from PEP-632: In Python 3.10 and 3.11, distutils will be formally marked as deprecated. All known issues will be closed at this time. I close this bpo. If there have some block issues to discuss, we can reopen it again:)

BPO-30925:

Distutils is now deprecated (see PEP 632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils.

If this issue does not relate to distutils, please remove the component and reopen it. If you believe it still requires a fix, most likely the issue should be re-reported at https://github.com/pypa/setuptools

@hugovk hugovk closed this Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting changes stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@warthog9 @the-knights-who-say-ni @mention-bot @kushaldas @flavianh @csabella @nightlark @hugovk @brettcannon @zware