Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39127: Make _Py_HashPointer's argument be const #17690
Conversation
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Dec 24, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This comment has been minimized.
This comment has been minimized.
|
I have indeed signed the CLA, but it was just earlier this evening. |
This comment has been minimized.
This comment has been minimized.
|
@serhiy-storchaka If I find more instances of changes like this, should I submit each one individually, or put them all together in a single PR? |
This comment has been minimized.
This comment has been minimized.
|
It looks like my CLA has gone through. I have my asterisk in bpo. Should I do something to retrigger the checks? |
petdance commentedDec 24, 2019
•
edited by bedevere-bot
_Py_HashPointerin Python/pyhash.c takes a pointer argument that can be madeconst. This will let compiler and static analyzers know that the pointer's target is not modified. You can also change calls to_Py_HashPointerthat are down-casting pointers.For example, in
meth_hashin Objects/methodobject.c, this call can have thevoid *changed toconst void *.https://bugs.python.org/issue39127