Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39307: Fix memory leak on error path in parsetok #17953

Merged
merged 1 commit into from Jan 13, 2020
Merged

bpo-39307: Fix memory leak on error path in parsetok #17953

merged 1 commit into from Jan 13, 2020

Conversation

@alexhenrie
Copy link
Contributor

alexhenrie commented Jan 11, 2020 •
edited by bedevere-bot

A straightforward fix.

https://bugs.python.org/issue39307
@alexhenrie
bpo-39307: Fix memory leak on error path in parsetok
Loading status checks…
6f77bb5
@csabella csabella requested a review from ilevkivskyi Jan 12, 2020
@pablogsal pablogsal self-requested a review Jan 13, 2020
@pablogsal pablogsal self-assigned this Jan 13, 2020
@pablogsal
pablogsal approved these changes Jan 13, 2020
View changes
Copy link
Member

pablogsal left a comment

LGTM
@pablogsal pablogsal merged commit 7ba6f18 into python:master Jan 13, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200111.32 succeeded
Details
bedevere/issue-number Issue number 39307 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 13, 2020

Thanks @alexhenrie for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 13, 2020
@alexhenrie @miss-islington
bpo-39307: Fix memory leak on error path in parsetok (pythonGH-17953)
d7713c9 
(cherry picked from commit 7ba6f18)

Co-authored-by: Alex Henrie <alexhenrie24@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 13, 2020

GH-17978 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 13, 2020
@alexhenrie @miss-islington
bpo-39307: Fix memory leak on error path in parsetok (pythonGH-17953)
e2fdaca 
(cherry picked from commit 7ba6f18)

Co-authored-by: Alex Henrie <alexhenrie24@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 13, 2020

GH-17979 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Jan 13, 2020
@miss-islington @alexhenrie
bpo-39307: Fix memory leak on error path in parsetok (GH-17953)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9671b6b 
(cherry picked from commit 7ba6f18)

Co-authored-by: Alex Henrie <alexhenrie24@gmail.com>
sthagen added a commit to sthagen/cpython that referenced this pull request Jan 13, 2020
@sthagen
Merge pull request #168 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3efb59b 
bpo-39307: Fix memory leak on error path in parsetok (pythonGH-17953)
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@alexhenrie @petdance
bpo-39307: Fix memory leak on error path in parsetok (pythonGH-17953)
ae98daf
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@alexhenrie @petdance
bpo-39307: Fix memory leak on error path in parsetok (pythonGH-17953)
81e9ccd
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
@alexhenrie @petdance
bpo-39307: Fix memory leak on error path in parsetok (pythonGH-17953)
697bcff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@ilevkivskyi ilevkivskyi

Assignees

@pablogsal pablogsal

Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
6 participants
@alexhenrie @miss-islington @bedevere-bot @pablogsal @ammaraskar @the-knights-who-say-ni
You can’t perform that action at this time.