Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39313: Add an option to RefactoringTool for using exec as a function #17967

Merged
merged 4 commits into from Jan 12, 2020
Merged

bpo-39313: Add an option to RefactoringTool for using exec as a function #17967

merged 4 commits into from Jan 12, 2020
+23 −8

Conversation

@isidentical
Copy link
Contributor

isidentical commented Jan 12, 2020 •
edited by pablogsal

https://bugs.python.org/issue39313

Automerge-Triggered-By: @pablogsal
@isidentical
bpo-39313: Add an option to RefactoringTool for using no_print_and_ex…
Loading status checks…
6e05f08 
…ec grammar
@pablogsal
pablogsal requested changes Jan 12, 2020
View changes
Lib/lib2to3/main.py Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 12, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@isidentical
add -e option
Loading status checks…
2b19ce3
@isidentical isidentical changed the title bpo-39313: Add an option to RefactoringTool for using no_print_and_exec_statement bpo-39313: Add an option to RefactoringTool for using exec as a function Jan 12, 2020
@isidentical

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

isidentical commented Jan 12, 2020

I have made the requested changes; please review again
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 12, 2020

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from pablogsal Jan 12, 2020
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Misc/NEWS.d/next/Library/2020-01-12-18-17-00.bpo-39313.DCTsnm.rst Outdated Show resolved Hide resolved
@isidentical
update news entry
Loading status checks…
1598a13
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Misc/NEWS.d/next/Library/2020-01-12-18-17-00.bpo-39313.DCTsnm.rst Outdated Show resolved Hide resolved
@pablogsal
pablogsal approved these changes Jan 12, 2020
View changes
Copy link
Member

pablogsal left a comment

LCTM
@pablogsal
pablogsal reviewed Jan 12, 2020
View changes
Misc/NEWS.d/next/Library/2020-01-12-18-17-00.bpo-39313.DCTsnm.rst Outdated Show resolved Hide resolved
@isidentical
improve news entry
Loading status checks…
3665617
@isidentical isidentical force-pushed the isidentical:bpo-39313 branch from 06c2d15 to 3665617 Jan 12, 2020
@isidentical isidentical requested a review from pablogsal Jan 12, 2020
@pablogsal pablogsal self-assigned this Jan 12, 2020
@pablogsal
pablogsal approved these changes Jan 12, 2020
View changes
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 12, 2020

@isidentical: Status check is done, and it's a success ✅ .
@miss-islington miss-islington merged commit 61b1415 into python:master Jan 12, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200112.43 succeeded
Details
bedevere/issue-number Issue number 39313 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees

@pablogsal pablogsal

Labels
🤖 automerge CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@isidentical @bedevere-bot @miss-islington @pablogsal @the-knights-who-say-ni
You can’t perform that action at this time.