[3.6] bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff (GH-10639) #11477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-10639) (cherry picked from commit cbb1645) Co-authored-by: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
orsenthil
approved these changes
Jan 9, 2019
eamanu
approved these changes
Jan 9, 2019
|
@CuriousLearner and @orsenthil: Status check is done, and it's a success ✅ . |
|
Sorry, I can't merge this PR. Reason: |
|
@orsenthil: Please replace |
|
Sorry that it's off topic but I am just curious if 3.6 accepts bug fixes since it has moved into security fix only mode. |
|
Please don't merge bugfixes in the 3.6: it's now in security-only mode... Moreover, this change caused a regression :-( https://bugs.python.org/issue24746#msg333367 |
orsenthil
added a commit
that referenced
this pull request
Jan 10, 2019
ned-deily
pushed a commit
that referenced
this pull request
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit cbb1645)
Co-authored-by: Sanyam Khurana 8039608+CuriousLearner@users.noreply.github.com
https://bugs.python.org/issue24746