[3.6] bpo-35486: Note Py3.6 import system API requirement change (GH-11540) #11588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11540) While the introduction of ModuleNotFoundError was fully backwards compatible on the import API consumer side, folks providing alternative implementations of `__import__` need to make an update to be forward compatible with clients that start relying on the new subclass. https://bugs.python.org/issue35486 (cherry picked from commit cee29b4) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
|
@ncoghlan: Status check is done, and it's a success ✅ . |
ncoghlan
approved these changes
Jan 17, 2019
|
Sorry, I can't merge this PR. Reason: |
|
@ned-deily This one's going to need your RM powers to merge, as the branch is past its normal maintenance period. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the introduction of ModuleNotFoundError was fully backwards
compatible on the import API consumer side, folks providing alternative
implementations of
__import__need to make an update to beforward compatible with clients that start relying on the new subclass.
https://bugs.python.org/issue35486
(cherry picked from commit cee29b4)
Co-authored-by: Nick Coghlan ncoghlan@gmail.com
https://bugs.python.org/issue35486