New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-33816: Remove outdated metaclass example #7566
Conversation
Perhaps it would make sense to keep the example, but caveat it as being redundant given the move to class namespaces being ordered by default? |
The thing is that the example also depends on the fact that a specialized type like OrderedDict was needed to get an insertion-order-preserving dictionary. I think examples of the like "that thing can be implemented with this API like this:" are good, but this particular example depends on several things that have changed. IMHO, a new example that shows a real benefit from metaclasses would be better. |
I think we must not waiting removing bad document until someone writing better document Additionally, metaclass is very complex feature. I don't want to promote using it. Lack of "typical usecase" is OK. Lack of "example of typical usecase" is OK too. |
Thanks @andresdelfino for the PR, and @methane for merging it |
(cherry picked from commit c2ccac7) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
GH-10567 is a backport of this pull request to the 3.7 branch. |
GH-10568 is a backport of this pull request to the 3.6 branch. |
(cherry picked from commit c2ccac7) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
https://bugs.python.org/issue33816