Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark importlib and clinic headers as generated #7619

Merged
merged 2 commits into from Jun 15, 2018
Merged

Mark importlib and clinic headers as generated #7619

merged 2 commits into from Jun 15, 2018
+17 −0

Conversation

@methane
Copy link
Member

methane commented Jun 11, 2018 •
edited

We can specify generated files in .gitattributes.
Github doesn't render diff for generated files by default.

Sample pull request
@methane
Mark importlib and clinic headers as generated
Loading status checks…
b767661
@methane methane requested a review from zware Jun 12, 2018
@zware
zware reviewed Jun 13, 2018
View changes
Copy link
Member

zware left a comment

Looks good, but there are several other generated files that we could also list here, like the unicodedata files, graminit, python-ast, etc.
@zware

This comment has been minimized.

Sign in to view
Copy link
Member

zware commented Jun 13, 2018 •
edited

I removed the needs backport to 2.7 label; clinic and importlib*.h don't exist in 2.7.
@methane
List more files as generated
Loading status checks…
7064fad
@zware
zware approved these changes Jun 15, 2018
View changes
Copy link
Member

zware left a comment

LGTM.
@serhiy-storchaka

This comment has been minimized.

Sign in to view
Copy link
Member

serhiy-storchaka commented Jun 15, 2018

It doesn't hide diffs completely, but just makes them collapsed by default? Then LGTM!
@methane methane merged commit c1897ed into python:master Jun 15, 2018
9 checks passed
9 checks passed
VSTS: Linux-PR Linux-PR_20180615.23 succeeded
Details
VSTS: Linux-PR-Coverage Linux-PR-Coverage_20180615.25 succeeded
Details
VSTS: Windows-PR Windows-PR_20180615.23 succeeded
Details
VSTS: docs docs_20180615.28 succeeded
Details
VSTS: macOS-PR macOS-PR_20180615.23 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jun 15, 2018

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 15, 2018

GH-7707 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 15, 2018
@methane @miss-islington
gitattribute: Mark generated files (pythonGH-7619)
9ffa29d 
Marked files are collapsed by default in Github pull request.
https://github.com/github/linguistGH-generated-code
(cherry picked from commit c1897ed)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jun 15, 2018

GH-7708 is a backport of this pull request to the 3.6 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 15, 2018
@methane @miss-islington
gitattribute: Mark generated files (pythonGH-7619)
692ed26 
Marked files are collapsed by default in Github pull request.
https://github.com/github/linguistGH-generated-code
(cherry picked from commit c1897ed)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
@methane

This comment has been minimized.

Sign in to view
Copy link
Member Author

methane commented Jun 15, 2018

miss-islington added a commit that referenced this pull request Jun 15, 2018
@miss-islington @methane
gitattribute: Mark generated files (GH-7619)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9363235 
Marked files are collapsed by default in Github pull request.
https://github.com/github/linguistGH-generated-code
(cherry picked from commit c1897ed)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jun 15, 2018
@miss-islington @methane
gitattribute: Mark generated files (GH-7619)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d85d479 
Marked files are collapsed by default in Github pull request.
https://github.com/github/linguistGH-generated-code
(cherry picked from commit c1897ed)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
lisroach added a commit to lisroach/cpython that referenced this pull request Sep 10, 2018
@methane @lisroach
gitattribute: Mark generated files (pythonGH-7619)
83a3e32 
Marked files are collapsed by default in Github pull request.
https://github.com/github/linguist#generated-code
yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
@methane @yahya-abou-imran
gitattribute: Mark generated files (pythonGH-7619)
b408d37 
Marked files are collapsed by default in Github pull request.
https://github.com/github/linguist#generated-code
@methane methane deleted the methane:generated branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware

Assignees
No one assigned
Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
6 participants
@methane @zware @serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.