Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify, for BaseHTTPRequestHandler, that path includes query #16884

Closed
wants to merge 1 commit into from
Closed

Clarify, for BaseHTTPRequestHandler, that path includes query #16884

wants to merge 1 commit into from
+4 −0

Conversation

@drj11
Copy link
Contributor

@drj11 drj11 commented Oct 22, 2019

A minor improvement to the documentation for BaseHTTPRequestHandler in the http.server library.
Pointing that the path attribute also includes the query part, when present.
@drj11
Clarify, for BaseHTTPRequestHandler, that path includes query
Loading status checks…
9da8e92
@eamanu
eamanu approved these changes Oct 22, 2019
View changes
@drj11
Copy link
Contributor Author

@drj11 drj11 commented Oct 30, 2019

Can someone please add skip label and skip news? Thanks!
@csabella csabella requested a review from orsenthil Jan 11, 2020
@orsenthil
orsenthil requested changes Jan 11, 2020
View changes
Copy link
Member

@orsenthil orsenthil left a comment

The content looks good to me. Please make sure to format it at 80 column wrap for better readability.
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 11, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@csabella
Copy link
Contributor

@csabella csabella commented May 28, 2020

@drj11, please make the requested changes. Thanks!
@orsenthil orsenthil mentioned this pull request Apr 25, 2021
Open
@orsenthil
Copy link
Member

@orsenthil orsenthil commented Apr 25, 2021

Superseded by #25597
@orsenthil orsenthil closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil

@eamanu eamanu

Assignees
No one assigned
Labels
CLA signed awaiting changes skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@drj11 @bedevere-bot @csabella @orsenthil @eamanu @the-knights-who-say-ni