Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39372: Clean header files of declared interfaces with no implementations #18037
Conversation
…tations
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 17, 2020
If you want to schedule another build, you need to add the " |
LGTM, except that the C API section is more appropriate for the NEWS entry. |
@@ -22,8 +22,6 @@ typedef PyObject *(*PyCFunctionWithKeywords)(PyObject *, PyObject *, | |||
typedef PyObject *(*_PyCFunctionFastWithKeywords) (PyObject *, | |||
PyObject *const *, Py_ssize_t, | |||
PyObject *); | |||
typedef PyObject *(*PyNoArgsFunction)(PyObject *); |
This comment has been minimized.
This comment has been minimized.
serhiy-storchaka
Jan 17, 2020
Member
This is the definition. But it is not used, and never was used in CPython, and using it in extensions is likely an indication of an error.
@@ -81,8 +81,6 @@ PyAPI_FUNC(int) PyImport_ImportFrozenModule( | |||
const char *name /* UTF-8 encoded string */ | |||
); | |||
|
|||
PyAPI_DATA(PyTypeObject) PyNullImporter_Type; |
This comment has been minimized.
This comment has been minimized.
serhiy-storchaka
Jan 17, 2020
Member
It was implemented in 3.2. Removing the implementation in 3.3 was technically the breakage of the stable ABI. But is too late to fix this.
Misc/NEWS.d/next/Core and Builtins/2020-01-17-17-51-05.bpo-39372.0IXPJZ.rst
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,9 @@ | |||
Clean header files of interfaces defined but with no implementation. The | |||
public API symbols being removed are: | |||
|
This comment has been minimized.
This comment has been minimized.
serhiy-storchaka
Jan 17, 2020
Member
I afraid that using multi-paragraph news entry can cause problems when files be merged into a single NEWS file.
This comment has been minimized.
This comment has been minimized.
pablogsal
Jan 17, 2020
•
Author
Member
Thanks for pointing that out! ... it was too good to be true (I couldn't check at the time I pushed this change).
cd7db76
into
python:master
This comment has been minimized.
This comment has been minimized.
Thanks, Serhiy for the review! |
This comment has been minimized.
This comment has been minimized.
Thank you for your great work! |
pablogsal commentedJan 17, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39372