Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39160 Align the verbs, grammar and defaults for `./configure --help` #17747
Conversation
This comment has been minimized.
This comment has been minimized.
Also requesting review from @Yhg1s (if the expert index is up to date). Although this doesn't change any behaviours in autoconf |
Unix install. optional INSTALLDIR specifies the | ||
installation path. see Mac/README.rst (default is | ||
no) | ||
--enable-shared enable building a shared Python library (default is |
This comment has been minimized.
This comment has been minimized.
tonybaloney
Dec 30, 2019
Author
Contributor
As a follow on. This needs more documentation somewhere, it's only referenced in the release notes
enable C locale coercion to a UTF-8 based locale | ||
(default is yes) | ||
--with-valgrind enable Valgrind support (default is no) | ||
--with-dtrace enable DTrace support (default is no) |
This comment has been minimized.
This comment has been minimized.
tonybaloney
Dec 30, 2019
Author
Contributor
I think the dtrace support also needs documenting somewhere, it's a really useful feature when you know how to use it. It's not mentioned in the profiling section of docs
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 30, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This comment has been minimized.
This comment has been minimized.
I have made the requested changes; please review again |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 30, 2019
Thanks for making the requested changes! @Yhg1s: please review the changes made to this pull request. |
@ned-deily should review the framework help strings, since I don't know much about that. |
AS_HELP_STRING([--with-cxx-main=<compiler>], | ||
[compile main() and link python executable with C++ compiler]), | ||
AS_HELP_STRING([--with-cxx-main@<:@=COMPILER@:>@], | ||
[compile main() and link Python executable with C++ compiler specified in COMPILER (default is $CXX)]), |
This comment has been minimized.
This comment has been minimized.
Yhg1s
Jan 2, 2020
Member
This is a little misleading: the default is not to link with CXX at all, although the default value when passing --with-cxx-main
is indeed CXX. (As an aside, I don't think this option is useful anymore; I believe it was only necessary with gcc 2.95, perhaps only on some platforms.)
This comment has been minimized.
This comment has been minimized.
thanks, @Yhg1s, the framework help strings are copied from |
Looks good to me. It's a nice improvement, thanks! I'm going to merge the PR as it stands. If you want to follow up on the suggestions for additional changes, let's open another PR for that. |
2de064e
into
python:master
…lp` (pythonGH-17747)
…lp` (pythonGH-17747)
…lp` (pythonGH-17747)
tonybaloney commentedDec 30, 2019
•
edited by bedevere-bot
Updated version based on principles:
--with(out)-xyz
in help string, it's implied by default--with-xyx=VALUE
will be described as "overriding"--with-xyz
will be described as "enabling" said featurehttps://bugs.python.org/issue39160