Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-39279: Don't allow non-Ascii digits in platform.py #17928
Conversation
This comment has been minimized.
This comment has been minimized.
|
@ezio-melotti @bitdancer This touches code that you were the last to touch, a few years ago. Care to comment? |
|
If the change is approved, I think it would be better to add a few tests to make sure that the code still works (if they are not there already) and that it rejects non-ASCII digits properly. |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 10, 2020
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
cool-RR commentedJan 9, 2020
•
edited by bedevere-bot
The
platform.pymodule takes non-Ascii digits in regexes in places it shouldn't. e.g. digits like ٢ and ５ and accepted, when only the Ascii digits between 0-9 should be accepted.https://bugs.python.org/issue39279