Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38901: Allow setting a venv's prompt to the basename of the current directory. #17946
+16
−1
Conversation
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
@brettcannon - as the original reporter - any comments before I merge this? |
This comment has been minimized.
This comment has been minimized.
|
@vsajip my only comment is |
vsajip
merged commit 7d63780
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
…nt directory. (pythonGH-17946) When a prompt value of '.' is specified, os.path.basename(os.getcwd()) is used to configure the prompt for the created venv.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
…nt directory. (pythonGH-17946) When a prompt value of '.' is specified, os.path.basename(os.getcwd()) is used to configure the prompt for the created venv.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
…nt directory. (pythonGH-17946) When a prompt value of '.' is specified, os.path.basename(os.getcwd()) is used to configure the prompt for the created venv.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vsajip commentedJan 10, 2020
•
edited by bedevere-bot
When a prompt value of '.' is specified,
os.path.basename(os.getcwd())is used to configure the prompt for the created venv.https://bugs.python.org/issue38901