Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38704: Prevent installation on unsupported Windows versions #17950

Open
wants to merge 1 commit into
base: master
from

Conversation

@ZackerySpytz
Copy link
Contributor

ZackerySpytz commented Jan 11, 2020

@ZackerySpytz ZackerySpytz requested a review from python/windows-team as a code owner Jan 11, 2020
@ZackerySpytz

This comment has been minimized.

Copy link
Contributor Author

ZackerySpytz commented Jan 11, 2020

I guess Py_WINVER et al. should be updated as well.

There was also some discussion on https://bugs.python.org/issue32592 w.r.t. dropping Windows < 8.1.

@zooba

This comment has been minimized.

Copy link
Member

zooba commented Jan 14, 2020

@ZackerySpytz I think you're missing some changes to msi\bundle\Default.wxl for the updated string references.

Have you been able to build the MSI? It should pull down any dependencies automatically and be fairly straightforward if you run the tools/msi/build.bat script.

@zooba zooba self-assigned this Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.