Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-39259: smtp.SMTP/SMTP_SSL now reject timeout = 0 #17958
Conversation
This comment has been minimized.
This comment has been minimized.
@vstinner During I work on this PR, I've noticed that LMTP does not support the timeout parameter. However, LMTP also able to use the socket which is created from SMTP. Line 1076 in 100fafc IMHO LMTP needs to support the timeout parameter.
Also AFAIK, Unix Socket also able to set a timeout which is used for LMTP protocol |
This comment has been minimized.
This comment has been minimized.
If you think so, please open a separated issue. It's not directly related to https://bugs.python.org/issue39259 |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 13, 2020
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
I have made the requested changes; please review again |
62e3973
into
python:master
corona10 commentedJan 12, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39259