Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39329: Add timeout parameter for LMTP #17998

Merged
merged 2 commits into from Jan 14, 2020
Merged

Conversation

@corona10
Copy link
Member

corona10 commented Jan 14, 2020

@corona10 corona10 requested a review from python/email-team as a code owner Jan 14, 2020
@corona10 corona10 requested a review from vstinner Jan 14, 2020
Copy link
Member

vstinner left a comment

You should document the new parameter at https://docs.python.org/dev/library/smtplib.html#smtplib.LMTP : update the function and add a "versionchanged 3.9" markup (see other files for the exact syntax, look at os.rst maybe). You can also document the new feature in Doc/whatsnew/3.9.rst

@corona10 corona10 changed the title [WIP] bpo-39329: Add timeout parameter for LMTP bpo-39329: Add timeout parameter for LMTP Jan 14, 2020
@corona10 corona10 force-pushed the corona10:bpo-39329 branch 2 times, most recently from b19af6f to a54467e Jan 14, 2020
@corona10 corona10 force-pushed the corona10:bpo-39329 branch from a54467e to 7a220ff Jan 14, 2020
Copy link
Member Author

corona10 left a comment

@vstinner
Please take a look.
Question:
For this PR, some tests codes are updated for these, is it okay to apply PEP8?
e.g: testBasic1 -> test_basic1

@corona10 corona10 requested a review from vstinner Jan 14, 2020
Doc/library/smtplib.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
Lib/test/test_smtplib.py Outdated Show resolved Hide resolved
@corona10 corona10 requested a review from vstinner Jan 14, 2020
@corona10

This comment has been minimized.

Copy link
Member Author

corona10 commented Jan 14, 2020

@vstinner Updated!

@vstinner vstinner merged commit 65a5ce2 into python:master Jan 14, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200114.17 succeeded
Details
bedevere/issue-number Issue number 39329 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
petdance added a commit to petdance/cpython that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.