Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39348: Fix code highlight for the SOCK_NONBLOCK example #18018
+3
−1
Conversation
The previous double colon was wrongly place directly after Therefore. Which produced a block without syntax highlighting. This fixes it by separating the double colon from the text. As a result, sphinx now properly nightlights the python code.
This comment has been minimized.
This comment has been minimized.
|
Yes, good catch. Thanks! |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 15, 2020
|
Thanks @oz123 for the PR |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 15, 2020
…-18018) The previous double colon was wrongly place directly after Therefore. Which produced a block without syntax highlighting. This fixes it by separating the double colon from the text. As a result, sphinx now properly highlights the python code. https://bugs.python.org/issue39348 (cherry picked from commit fad8b56) Co-authored-by: Oz N Tiram <oz.tiram@noris.de>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 15, 2020
|
GH-18019 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 15, 2020
…-18018) The previous double colon was wrongly place directly after Therefore. Which produced a block without syntax highlighting. This fixes it by separating the double colon from the text. As a result, sphinx now properly highlights the python code. https://bugs.python.org/issue39348 (cherry picked from commit fad8b56) Co-authored-by: Oz N Tiram <oz.tiram@noris.de>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 15, 2020
|
GH-18020 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 16, 2020
The previous double colon was wrongly place directly after Therefore. Which produced a block without syntax highlighting. This fixes it by separating the double colon from the text. As a result, sphinx now properly highlights the python code. https://bugs.python.org/issue39348 (cherry picked from commit fad8b56) Co-authored-by: Oz N Tiram <oz.tiram@noris.de>
miss-islington
added a commit
that referenced
this pull request
Jan 16, 2020
The previous double colon was wrongly place directly after Therefore. Which produced a block without syntax highlighting. This fixes it by separating the double colon from the text. As a result, sphinx now properly highlights the python code. https://bugs.python.org/issue39348 (cherry picked from commit fad8b56) Co-authored-by: Oz N Tiram <oz.tiram@noris.de>
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
…-18018) The previous double colon was wrongly place directly after Therefore. Which produced a block without syntax highlighting. This fixes it by separating the double colon from the text. As a result, sphinx now properly highlights the python code. https://bugs.python.org/issue39348
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
…-18018) The previous double colon was wrongly place directly after Therefore. Which produced a block without syntax highlighting. This fixes it by separating the double colon from the text. As a result, sphinx now properly highlights the python code. https://bugs.python.org/issue39348
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
…-18018) The previous double colon was wrongly place directly after Therefore. Which produced a block without syntax highlighting. This fixes it by separating the double colon from the text. As a result, sphinx now properly highlights the python code. https://bugs.python.org/issue39348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
oz123 commentedJan 15, 2020
•
edited by miss-islington
The previous double colon was wrongly place directly after Therefore.
Which produced a block without syntax highlighting. This fixes it
by separating the double colon from the text. As a result, sphinx now
properly highlights the python code.
https://bugs.python.org/issue39348
Automerge-Triggered-By: @Mariatta