New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39366: Remove xpath() and xgtitle() methods of NNTP. #18035

Open

corona10 wants to merge 3 commits into python:master from corona10:bpo-39336

+8 −65

Member

corona10 commented Jan 17, 2020 •

edited

https://bugs.python.org/issue39366

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting review label

corona10 requested a review from vstinner

corona10 changed the title ~~bpo-39336: Remove xpath() and xgtitle() methods of NNTP.~~ bpo-39366: Remove xpath() and xgtitle() methods of NNTP.


        bpo-39366: Remove xpath() and xgtitle() methods of NNTP.

3c9748d

corona10 force-pushed the corona10:bpo-39336 branch from b5d47c4 to 3c9748d

vstinner reviewed

Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved


        bpo-39366: Doc update

e8868ed

corona10 force-pushed the corona10:bpo-39336 branch from 075d0f2 to e8868ed

vstinner approved these changes

Member

vstinner left a comment

LGTM. But I would prefer to have a second review, since I'm not used to nntplib.

@serhiy-storchaka @vadmium @berkerpeksag @pitrou: Can one of you please review this PR as well? Well, IMO the PR itself is fine, the question is more if you are ok to drop these two deprecated methods.

Doc/whatsnew/3.9.rst Show resolved Hide resolved

bedevere-bot added awaiting merge and removed awaiting review labels


        bpo-39366: Update whatsnew 3.9

665cc7d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.