Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32989: IDLE - fix bad editor call of pyparse method #5968

Merged
merged 11 commits into from Jan 21, 2020
Merged

bpo-32989: IDLE - fix bad editor call of pyparse method #5968

merged 11 commits into from Jan 21, 2020
+154 −39

Conversation

@csabella
Copy link
Contributor

csabella commented Mar 3, 2018 •
edited by terryjreedy

Fix comments and add tests for editor newline_and_indent_event method.
Remove unused None default for function parameter of pyparse find_good_parse_start method
and code triggered by that default.

https://bugs.python.org/issue32989
@csabella
bpo-32989: IDLE: Correct call from editor to pyparse
Loading status checks…
5ddb22f
@csabella csabella requested a review from terryjreedy as a code owner Mar 3, 2018
@terryjreedy terryjreedy changed the title bpo-32989: IDLE: Correct call from editor to pyparse bpo-32989: IDLE - fix pyparse.find_good_parse_start None bug and bad call Mar 4, 2018
@terryjreedy terryjreedy changed the title bpo-32989: IDLE - fix pyparse.find_good_parse_start None bug and bad call bpo-32989: IDLE - fix pyparse.find_good_parse_start and bad editor call Mar 4, 2018
csabella added 2 commits Mar 5, 2018
@csabella
Remove is_char_in_string default and change test
Loading status checks…
fb917aa
@csabella
Merge branch 'master' into pyparse
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a7ea08a
@terryjreedy terryjreedy changed the title bpo-32989: IDLE - fix pyparse.find_good_parse_start and bad editor call bpo-35610: IDLE - fix pyparse.find_good_parse_start and bad editor call Dec 29, 2018
@terryjreedy terryjreedy changed the title bpo-35610: IDLE - fix pyparse.find_good_parse_start and bad editor call bpo-32989: IDLE - fix pyparse.find_good_parse_start and bad editor call Dec 29, 2018
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member

vstinner commented Jan 10, 2019

I removed the " needs backport to 3.6" label, the 3.6 branch no long accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches
@ZackerySpytz
ZackerySpytz reviewed Jan 15, 2020
View changes
Lib/idlelib/editor.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/IDLE/2018-03-03-12-56-26.bpo-32989.FVhmhH.rst Outdated Show resolved Hide resolved
terryjreedy added 4 commits Jan 15, 2020
@terryjreedy
Condense added comment.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
53394f9
@terryjreedy
Revise blurb.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1cecdf8
@terryjreedy
Adjust comment.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ce8666b
@terryjreedy
Tweak new find_good_parse_start tests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4cff2c6
@terryjreedy terryjreedy changed the title bpo-32989: IDLE - fix pyparse.find_good_parse_start and bad editor call bpo-32989: IDLE - fix bad editor call of pyparse method Jan 15, 2020
@terryjreedy terryjreedy self-assigned this Jan 15, 2020
@terryjreedy

This comment has been minimized.

Sign in to view
Copy link
Member

terryjreedy commented Jan 15, 2020 •
edited

I have reviewed and tweaked everything except the new indent tests, including the proposed commit message. Correct calls to find...start should work since they presumably did before the parameter was removed, but I want to check a bit more.

Edit: After merging master, I discovered that the call change was already done on another issue. The there should not be any behavior change with remaining patch.
terryjreedy added 4 commits Jan 21, 2020
@terryjreedy
Merge remote-tracking branch 'origin/master' into pr_5968
Loading status checks…
14266e9
@terryjreedy
Fix indent
a373bb8
@terryjreedy
Remove extraneous test code.
e061c5c
@terryjreedy
News item.
Loading status checks…
8a11319
@terryjreedy
terryjreedy approved these changes Jan 21, 2020
View changes
Copy link
Member

terryjreedy left a comment

Will merge when CI is done.
@terryjreedy terryjreedy merged commit ec64640 into python:master Jan 21, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200121.10 succeeded
Details
bedevere/issue-number Issue number 32989 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 21, 2020

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 21, 2020
@csabella @miss-islington
bpo-32989: IDLE - fix bad editor call of pyparse method (pythonGH-5968)
d50ef68 
Fix comments and add tests for editor newline_and_indent_event method.
Remove unused None default for function parameter of pyparse find_good_parse_start method
and code triggered by that default.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ec64640)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 21, 2020

GH-18096 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 21, 2020
@csabella @miss-islington
bpo-32989: IDLE - fix bad editor call of pyparse method (pythonGH-5968)
2cdeb6a 
Fix comments and add tests for editor newline_and_indent_event method.
Remove unused None default for function parameter of pyparse find_good_parse_start method
and code triggered by that default.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ec64640)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 21, 2020

GH-18097 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Jan 21, 2020
@miss-islington @csabella
bpo-32989: IDLE - fix bad editor call of pyparse method (GH-5968)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f3d3a3c 
Fix comments and add tests for editor newline_and_indent_event method.
Remove unused None default for function parameter of pyparse find_good_parse_start method
and code triggered by that default.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ec64640)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Jan 21, 2020
@miss-islington @csabella
bpo-32989: IDLE - fix bad editor call of pyparse method (GH-5968)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
060ad2f 
Fix comments and add tests for editor newline_and_indent_event method.
Remove unused None default for function parameter of pyparse find_good_parse_start method
and code triggered by that default.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit ec64640)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the csabella:pyparse branch Jan 21, 2020
@csabella

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

csabella commented Jan 21, 2020

Thanks, Terry!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz

@terryjreedy terryjreedy

Assignees

@terryjreedy terryjreedy

Labels
CLA signed
Projects
None yet
Milestone
No milestone
7 participants
@csabella @vstinner @terryjreedy @miss-islington @bedevere-bot @ZackerySpytz @the-knights-who-say-ni
You can’t perform that action at this time.