New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39383: Mention Darwin as a potential value for platform.system() #18054

Open

bittner wants to merge 1 commit into python:master from bittner:docs/mention-macos-platform-system

+2 −3

Contributor

bittner commented Jan 18, 2020 •

edited by bedevere-bot

This change mentions 'Darwin' as a possible value for

platform.system()

in the documentation of the platform module.

https://bugs.python.org/issue39383

the-knights-who-say-ni added the CLA signed label

bedevere-bot added type-documentation awaiting review labels

bittner changed the title ~~Mention Darwin as a potential value for platform.system()~~ bpo-39383: Mention Darwin as a potential value for platform.system()

Contributor

csabella commented Jan 18, 2020

I think this is a great suggestion, but I don't think you need the parenthetical for macOS.

ned-deily added needs backport to 3.7 needs backport to 3.8 skip news labels

ned-deily requested changes

Doc/library/platform.rst Outdated Show resolved Hide resolved

bedevere-bot removed the awaiting review label

bedevere-bot commented Jan 18, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot added the awaiting changes label


        Mention Darwin as a potential value for platform.system()

cc3ee08

bittner force-pushed the bittner:docs/mention-macos-platform-system branch from a8fb1bb to cc3ee08

Contributor Author

bittner commented Jan 19, 2020

I have made the requested changes; please review again.

bedevere-bot added awaiting change review and removed awaiting changes labels

bedevere-bot commented Jan 19, 2020

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

bedevere-bot requested a review from ned-deily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.