Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38809: Windows build scripts use python.exe from virtual envs #17164

Merged
merged 1 commit into from Nov 18, 2019
Merged

bpo-38809: Windows build scripts use python.exe from virtual envs #17164

merged 1 commit into from Nov 18, 2019
+5 −0

Conversation

@taleinat
Copy link
Contributor

taleinat commented Nov 15, 2019 •
edited by miss-islington

https://bugs.python.org/issue38809

Automerge-Triggered-By: @taleinat
@taleinat
bpo-38809: Windows build scripts use python.exe from virtual envs
Verified
This commit was signed with a verified signature.
taleinat Tal Einat
GPG key ID: 613A98AF4C800CDA Learn about signing commits
Loading status checks…
8a88085
@taleinat taleinat requested a review from zooba Nov 15, 2019
@taleinat taleinat requested a review from python/windows-team as a code owner Nov 15, 2019
@taleinat taleinat removed the request for review from zooba Nov 15, 2019
@zooba
zooba approved these changes Nov 18, 2019
View changes
@miss-islington miss-islington merged commit ee703cb into python:master Nov 18, 2019
4 checks passed
4 checks passed
Azure Pipelines PR #20191115.14 succeeded with issues
Details
bedevere/issue-number Issue number 38809 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Nov 18, 2019

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@taleinat taleinat deleted the taleinat:windows-find-python-virtualenvs branch Nov 18, 2019
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 18, 2019

GH-17237 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Nov 18, 2019
@taleinat @miss-islington
bpo-38809: Windows build scripts use python.exe from virtual envs (py…
e60eda6 
…thonGH-17164)

https://bugs.python.org/issue38809
(cherry picked from commit ee703cb)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Nov 18, 2019

GH-17238 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Nov 18, 2019
@miss-islington @taleinat
bpo-38809: Windows build scripts use python.exe from virtual envs (GH…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b928d9 
…-17164)

https://bugs.python.org/issue38809
(cherry picked from commit ee703cb)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Nov 18, 2019
@miss-islington @taleinat
bpo-38809: Windows build scripts use python.exe from virtual envs (GH…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cbbf109 
…-17164)

https://bugs.python.org/issue38809
(cherry picked from commit ee703cb)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@taleinat @jacobneiltaylor
bpo-38809: Windows build scripts use python.exe from virtual envs (py…
55d3a68 
…thonGH-17164)

https://bugs.python.org/issue38809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

Assignees
No one assigned
Labels
🤖 automerge CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@taleinat @miss-islington @bedevere-bot @zooba @the-knights-who-say-ni
You can’t perform that action at this time.