Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38589: Fixes HTML Help shortcut when Windows is not installed to C drive #16968

Merged
merged 1 commit into from Oct 28, 2019
Merged

bpo-38589: Fixes HTML Help shortcut when Windows is not installed to C drive #16968

merged 1 commit into from Oct 28, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Oct 28, 2019 •
edited by bedevere-bot

@zooba zooba requested a review from a team as a code owner Oct 28, 2019
@zooba zooba merged commit 0ac6137 into python:master Oct 28, 2019
@zooba zooba deleted the bpo-38589 branch Oct 28, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Oct 28, 2019

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Oct 28, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot
Copy link

bedevere-bot commented Oct 28, 2019

GH-16970 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 28, 2019

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 28, 2019

GH-16971 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2019
@zooba @miss-islington
bpo-38589: Fixes HTML Help shortcut when Windows is not installed to …
4987e14 
…C drive (pythonGH-16968)

(cherry picked from commit 0ac6137)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Oct 28, 2019
@miss-islington @zooba
bpo-38589: Fixes HTML Help shortcut when Windows is not installed to …
379b55b 
…C drive (GH-16968)

(cherry picked from commit 0ac6137)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Oct 28, 2019
@miss-islington @zooba
bpo-38589: Fixes HTML Help shortcut when Windows is not installed to …
2267cb9 
…C drive (GH-16968)

(cherry picked from commit 0ac6137)

Co-authored-by: Steve Dower <steve.dower@python.org>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@zooba
bpo-38589: Fixes HTML Help shortcut when Windows is not installed to …
6f5ff9b 
…C drive (pythonGH-16968)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@zooba @shihai1991
bpo-38589: Fixes HTML Help shortcut when Windows is not installed to …
04579df 
…C drive (pythonGH-16968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

Assignees
No one assigned
Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni