Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upminor: fix typo in test doc, fix flake8 issues #17856
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
Typo fix LGTM. I am not sure the whitespace changes are needed. There are other parts in stdlib that are also not flake8 compliant. |
This comment has been minimized.
This comment has been minimized.
|
ok, reverted - I've just thought it could be also fixed while at it. |
|
LGTM. Thanks. |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jan 9, 2020
|
Thanks @blueyed for the PR, and @tirkarthi for merging it |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jan 9, 2020
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jan 9, 2020
|
GH-17923 is a backport of this pull request to the 3.8 branch. |
This comment has been minimized.
This comment has been minimized.
|
Thanks @blueyed :) |
tirkarthi
added a commit
that referenced
this pull request
Jan 9, 2020
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
* Fix typo in test's docstring. contination -> continuation.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
* Fix typo in test's docstring. contination -> continuation.
petdance
added a commit
to petdance/cpython
that referenced
this pull request
Jan 17, 2020
* Fix typo in test's docstring. contination -> continuation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
blueyed commentedJan 6, 2020
No description provided.