Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-39259: ftplib.FTP/FTP_TLS now reject timeout = 0 #17959
Merged
Conversation
|
LGTM. |
| @@ -1045,6 +1045,10 @@ def testTimeoutValue(self): | |||
| self.evt.wait() | |||
| ftp.close() | |||
|
|
|||
| # bpo-39259 | |||
| with self.assertRaises(ValueError): | |||
| ftplib.FTP(HOST, timeout=0) | |||
This comment has been minimized.
This comment has been minimized.
vstinner
Jan 13, 2020
Member
FTP_TLS is not tested, but I don't think that its a big deal. FTP_TLS requires to check if ssl is available, and the current test suite isn't properly designed to test FTP and FTP_TLS at the same time.
vstinner
merged commit a190e2a
into
python:master
9 checks passed
9 checks passed
bedevere/news
News entry found in Misc/NEWS.d
sthagen
added a commit
to sthagen/cpython
that referenced
this pull request
Jan 13, 2020
bpo-39259: ftplib.FTP/FTP_TLS now reject timeout = 0 (pythonGH-17959)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
corona10 commentedJan 12, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39259