Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprises[3.7] bpo-39299: Add more tests for mimetypes and its cli. (GH-17949) #17991
+85
−5
Conversation
* Add tests for case insensitive check of types and extensions as fallback. * Add tests for data url with no comma. * Add tests for read_mime_types. * Add tests for the mimetypes cli and refactor __main__ code to private function. * Restore mimetypes.knownfiles value at the end of the test. (cherry picked from commit d8efc14) Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
@tirkarthi: Status check is done, and it's a success |
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
@tirkarthi: Status check is done, and it's a success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
miss-islington commentedJan 13, 2020
•
edited by bedevere-bot
(cherry picked from commit d8efc14)
Co-authored-by: Karthikeyan Singaravelan tir.karthi@gmail.com
https://bugs.python.org/issue39299