/cpython

bpo-27593: Get SCM build info from git instead of hg. #446

Merged
merged 1 commit into from Mar 4, 2017

Reviewers

@zooba zooba

@brettcannon brettcannon

Assignees

No one assigned

Labels

CLA signed needs backport to 2.7

Projects

None yet

Milestone

No milestone

5 participants

@ned-deily @AraHaan @zooba @the-knights-who-say-ni @Mariatta
@ned-deily
Member
ned-deily commented Mar 4, 2017

sys.version and the platform module python_build(),
python_branch(), and python_revision() functions now use
git information rather than hg when building from a repo.

Based on original patches by Brett Cannon and Steve Dower.
@ned-deily ned-deily bpo-27593: Get SCM build info from git instead of hg. 
sys.version and the platform module python_build(),
python_branch(), and python_revision() functions now use
git information rather than hg when building from a repo.

Based on original patches by Brett Cannon and Steve Dower.

All checks have passed

2 successful checks
@codecov
codecov/patch — 100% of diff hit (target 100%)
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
bdf933b
@ned-deily ned-deily requested review from brettcannon and zooba Mar 4, 2017
@AraHaan
AraHaan commented Mar 4, 2017 • edited

tbh it should be fore both in case someone clones it in hg, or in case they clone it in git. But overall I have no reason to disagree at all with this.

Also instead of changing hg on here to git why not just have both on the project files and the build script and such so that way they do not both have to be edited every time a file is added to the projects or whatever.
@zooba
zooba approved these changes Mar 4, 2017 View changes
@ned-deily ned-deily merged commit 5c4b0d0 into python:master Mar 4, 2017
2 checks passed

2 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ned-deily ned-deily deleted the ned-deily:bpo-27593 branch Mar 4, 2017
@ned-deily ned-deily added a commit to ned-deily/cpython that referenced this pull request Mar 4, 2017
@ned-deily ned-deily bpo-27593: Get SCM build info from git instead of hg. (#446) 
sys.version and the platform module python_build(),
python_branch(), and python_revision() functions now use
git information rather than hg when building from a repo.

Based on original patches by Brett Cannon and Steve Dower.
(cherry picked from commit 5c4b0d0)
 ac05af3
@ned-deily ned-deily added a commit to ned-deily/cpython that referenced this pull request Mar 4, 2017
@ned-deily ned-deily bpo-27593: Get SCM build info from git instead of hg. (#446) 
sys.version and the platform module python_build(),
python_branch(), and python_revision() functions now use
git information rather than hg when building from a repo.

Based on original patches by Brett Cannon and Steve Dower.
(cherry picked from commit 5c4b0d0)
 1fe0fc0
@ned-deily ned-deily added a commit that referenced this pull request Mar 4, 2017
@ned-deily ned-deily [3.6] bpo-27593: Get SCM build info from git instead of hg. (#446) (#454 
)

* bpo-27593: Get SCM build info from git instead of hg. (#446)

sys.version and the platform module python_build(),
python_branch(), and python_revision() functions now use
git information rather than hg when building from a repo.

Based on original patches by Brett Cannon and Steve Dower.
(cherry picked from commit 5c4b0d0)
 95c50e5
@ned-deily ned-deily added a commit to ned-deily/cpython that referenced this pull request Mar 4, 2017
@ned-deily ned-deily [3.5] bpo-27593: Get SCM build info from git instead of hg. (#446) (#454 
)

* bpo-27593: Get SCM build info from git instead of hg. (#446)

sys.version and the platform module python_build(),
python_branch(), and python_revision() functions now use
git information rather than hg when building from a repo.

Based on original patches by Brett Cannon and Steve Dower.
(cherry picked from commit 5c4b0d0)

(cherry picked from commit 95c50e5)
 19df91e
@ned-deily ned-deily referenced this pull request Mar 4, 2017
Merged

[3.5] bpo-27593: Get SCM build info from git instead of hg. (#446) #455

@ned-deily ned-deily added a commit that referenced this pull request Mar 4, 2017
@ned-deily ned-deily [3.5] bpo-27593: Get SCM build info from git instead of hg. (#446) (#454 
) (#455)

* bpo-27593: Get SCM build info from git instead of hg. (#446)

sys.version and the platform module python_build(),
python_branch(), and python_revision() functions now use
git information rather than hg when building from a repo.

Based on original patches by Brett Cannon and Steve Dower.
(cherry picked from commit 5c4b0d0)

(cherry picked from commit 95c50e5)
 a2edd3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment