Skip to content

[2.7] bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff #11482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2019
Merged

[2.7] bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff #11482

merged 2 commits into from
Jan 9, 2019

Conversation

CuriousLearner
Copy link
Member

@CuriousLearner CuriousLearner commented Jan 9, 2019 •
edited by bedevere-bot
Loading

CuriousLearner and others added 2 commits January 9, 2019 23:46
@CuriousLearner
bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff
85adb53
@CuriousLearner
[2.7] bpo-24746: Avoid stripping trailing whitespace in doctest fancy…
fa61282 
… diff (pythonGH-10639).

(cherry picked from commit cbb1645)

Co-authored-by: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
@CuriousLearner
Copy link
Member Author

Hi @orsenthil

Can you please have a look at this one?

orsenthil
orsenthil approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@orsenthil orsenthil merged commit 02e33d9 into python:2.7 Jan 9, 2019
@bedevere-bot
Copy link

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@orsenthil
Copy link
Member

Thanks again, @CuriousLearner !

@CuriousLearner
Copy link
Member Author

Thanks to you @orsenthil :)

I was waiting for my PRs to be reviewed for so long.

Many thanks! 🌮

orsenthil added a commit that referenced this pull request Jan 10, 2019
@orsenthil
Revert "[2.7] bpo-24746: Avoid stripping trailing whitespace in docte…
882aba4 
…st fancy diff (#11482)"

This reverts commit 02e33d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CuriousLearner @bedevere-bot @orsenthil @the-knights-who-say-ni