Skip to content

bpo-36235: Enhance distutils test_customize_compiler() #12403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2019
Merged

bpo-36235: Enhance distutils test_customize_compiler() #12403

merged 1 commit into from
Mar 18, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 18, 2019 •
edited by bedevere-bot
Loading

The test test_customize_compiler() now mocks all sysconfig variables
and all environment variables used by customize_compiler().

https://bugs.python.org/issue36235

@vstinner
bpo-36235: Enhance distutils test_customize_compiler()
8d1c842 
The test test_customize_compiler() now mocks all sysconfig variables
and all environment variables used by customize_compiler().
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Mar 18, 2019
eamanu
eamanu approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I test on Ubuntu 18.04

@yan12125 yan12125 mentioned this pull request Mar 18, 2019
Closed
@vstinner vstinner merged commit 72c7b37 into python:master Mar 18, 2019
@vstinner vstinner deleted the customize_compiler_test branch March 18, 2019 16:19
yan12125 added a commit to archlinuxcn/repo that referenced this pull request Mar 18, 2019
@yan12125
python-git: revert previous workaround - the issue is fixed
8bbf500 
Ref: python/cpython#12403
vstinner added a commit that referenced this pull request Mar 18, 2019
@vstinner
bpo-36235: Enhance distutils test_customize_compiler() (GH-12403) (GH…
dd1cfef 
…-12415)

The test test_customize_compiler() now mocks all sysconfig variables
and all environment variables used by customize_compiler().

(cherry picked from commit 72c7b37)
vstinner added a commit that referenced this pull request Mar 18, 2019
@vstinner
bpo-36235: Enhance distutils test_customize_compiler() (GH-12403) (GH…
8c380e9 
…-12417)

The test test_customize_compiler() now mocks all sysconfig variables
and all environment variables used by customize_compiler().

(cherry picked from commit 72c7b37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @eamanu @the-knights-who-say-ni @bedevere-bot