Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38301: In Solaris family, we must be sure to use '-D_REENTRANT' #16446

Merged
merged 1 commit into from Sep 28, 2019
Merged

bpo-38301: In Solaris family, we must be sure to use '-D_REENTRANT' #16446

merged 1 commit into from Sep 28, 2019

Conversation

jcea
Copy link
Member

@jcea jcea commented Sep 28, 2019 •
edited by bedevere-bot

@jcea jcea self-assigned this Sep 28, 2019
@jcea
Copy link
Member Author

jcea commented Sep 28, 2019 •
edited

Tested under SmartOS "joyent_20190829T000927Z", with pkgsrc "base-64 19.2.0". The patch is trivial and it only affects SunOS machines.

@jcea jcea merged commit 52d1b86 into python:master Sep 28, 2019
4 checks passed
@jcea jcea deleted the bpo-38301 branch Sep 28, 2019
@bedevere-bot
Copy link

bedevere-bot commented Sep 28, 2019

@jcea: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2019

Thanks @jcea for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2019

Sorry @jcea, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 52d1b86bde2b772a76919c76991c326384954bf1 3.7

@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2019

Sorry, @jcea, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 52d1b86bde2b772a76919c76991c326384954bf1 3.6

@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2019

Sorry @jcea, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 52d1b86bde2b772a76919c76991c326384954bf1 2.7

@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2019

Thanks @jcea for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 28, 2019

GH-16449 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2019

Thanks @jcea for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 28, 2019

GH-16450 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 28, 2019
@jcea @miss-islington
bpo-38301: In Solaris family, we must be sure to use '-D_REENTRANT' (p…
e390f3b 
…ythonGH-16446)

(cherry picked from commit 52d1b86)

Co-authored-by: Jesús Cea <jcea@jcea.es>
@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2019

Thanks @jcea for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 28, 2019

Sorry, @jcea, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 52d1b86bde2b772a76919c76991c326384954bf1 2.7

jcea added a commit that referenced this pull request Sep 28, 2019
@jcea
[3.6] bpo-38301: In Solaris family, we must be sure to use '-D_REENTR…
cbf04fd 
…ANT' (GH-16446).

(cherry picked from commit 52d1b86)

Co-authored-by: Jesús Cea <jcea@jcea.es>
jcea added a commit that referenced this pull request Sep 28, 2019
@miss-islington @jcea
bpo-38301: In Solaris family, we must be sure to use '-D_REENTRANT' (G…
8750bce 
…H-16446) (#16449)

(cherry picked from commit 52d1b86)

Co-authored-by: Jesús Cea <jcea@jcea.es>
jcea added a commit that referenced this pull request Sep 28, 2019
@miss-islington @jcea
bpo-38301: In Solaris family, we must be sure to use '-D_REENTRANT' (G…
6112b91 
…H-16446) (#16450)

(cherry picked from commit 52d1b86)

Co-authored-by: Jesús Cea <jcea@jcea.es>
@bedevere-bot
Copy link

bedevere-bot commented Sep 28, 2019

GH-16452 is a backport of this pull request to the 3.6 branch.

jcea added a commit that referenced this pull request Sep 28, 2019
@jcea
[2.7] bpo-38301: In Solaris family, we must be sure to use '-D_REENTR…
7987d99 
…ANT' (GH-16446).

(cherry picked from commit 52d1b86)

Co-authored-by: Jesús Cea <jcea@jcea.es>
@bedevere-bot
Copy link

bedevere-bot commented Sep 28, 2019

GH-16454 is a backport of this pull request to the 2.7 branch.

jcea added a commit that referenced this pull request Sep 28, 2019
@jcea
[2.7] bpo-38301: In Solaris family, we must be sure to use '-D_REENTR…
598f676 
…ANT' (GH-16446). (#16454)

(cherry picked from commit 52d1b86)

Co-authored-by: Jesús Cea <jcea@jcea.es>
@jcea jcea mentioned this pull request Sep 28, 2019
Open
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@jcea @jacobneiltaylor
bpo-38301: In Solaris family, we must be sure to use '-D_REENTRANT' (p…
7b3b9dd 
…ython#16446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcea jcea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcea @bedevere-bot @miss-islington @the-knights-who-say-ni