Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34369: make kqueue.control() docs better reflect that timeout is positional-only #9499

Merged
merged 2 commits into from Jul 11, 2019
Merged

bpo-34369: make kqueue.control() docs better reflect that timeout is positional-only #9499

merged 2 commits into from Jul 11, 2019

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Sep 22, 2018 •
edited by bedevere-bot

This improves consistency with the rest of the select module's doc page, e.g. select.select().

https://bugs.python.org/issue34369

@taleinat taleinat closed this Sep 22, 2018
@taleinat taleinat reopened this Sep 22, 2018
@taleinat taleinat requested review from berkerpeksag and vadmium Sep 26, 2018
@vstinner
Copy link
Member

vstinner commented Jan 10, 2019

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@taleinat
Copy link
Contributor Author

taleinat commented Jul 3, 2019

With the new positional-only argument syntax in 3.8, perhaps we should use that syntax in these docs?

vstinner
vstinner reviewed Jul 3, 2019
View changes
Doc/library/select.rst Show resolved Hide resolved
@vstinner
Copy link
Member

vstinner commented Jul 3, 2019 •
edited

I suggest to leave 3.8 doc unchanged: see https://bugs.python.org/issue37134 discussion and so only modify the doc in the master branch.

cc @pablogsal

@taleinat
Copy link
Contributor Author

taleinat commented Jul 11, 2019

I suggest to leave 3.8 doc unchanged: see https://bugs.python.org/issue37134 discussion and so only modify the doc in the master branch.

According to the steering council decision, we shouldn't use PEP 580 syntax here at all until further notice.

@taleinat taleinat merged commit 79042ac into python:master Jul 11, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Jul 11, 2019

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 11, 2019

GH-14704 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 11, 2019
@taleinat @miss-islington
bpo-34369: make kqueue.control() docs better reflect that timeout is …
d5f93dc 
…positional-only (pythonGH-9499)

(cherry picked from commit 79042ac)

Co-authored-by: Tal Einat <taleinat@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 11, 2019

GH-14705 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 11, 2019
@taleinat @miss-islington
bpo-34369: make kqueue.control() docs better reflect that timeout is …
9ce38ed 
…positional-only (pythonGH-9499)

(cherry picked from commit 79042ac)

Co-authored-by: Tal Einat <taleinat@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 11, 2019

GH-14706 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 11, 2019
@taleinat @miss-islington
bpo-34369: make kqueue.control() docs better reflect that timeout is …
85ca12a 
…positional-only (pythonGH-9499)

(cherry picked from commit 79042ac)

Co-authored-by: Tal Einat <taleinat@gmail.com>
@taleinat taleinat deleted the bpo-34369/kqueue-control-positional-only-param-docs branch Jul 11, 2019
miss-islington added a commit that referenced this pull request Jul 11, 2019
@miss-islington @taleinat
bpo-34369: make kqueue.control() docs better reflect that timeout is …
dc0b6af 
…positional-only (GH-9499)

(cherry picked from commit 79042ac)

Co-authored-by: Tal Einat <taleinat@gmail.com>
taleinat added a commit that referenced this pull request Jul 11, 2019
@miss-islington @taleinat
bpo-34369: make kqueue.control() docs better reflect that timeout is …
d3747fd 
…positional-only (GH-9499)

(cherry picked from commit 79042ac)

Co-authored-by: Tal Einat <taleinat@gmail.com>
taleinat added a commit that referenced this pull request Jul 11, 2019
@miss-islington @taleinat
bpo-34369: make kqueue.control() docs better reflect that timeout is …
46c2eff 
…positional-only (GH-9499)

(cherry picked from commit 79042ac)

Co-authored-by: Tal Einat <taleinat@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@taleinat @lisroach
bpo-34369: make kqueue.control() docs better reflect that timeout is …
a0afd6b 
…positional-only (pythonGH-9499)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@taleinat @DinoV
bpo-34369: make kqueue.control() docs better reflect that timeout is …
53d0cde 
…positional-only (pythonGH-9499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag

@vstinner vstinner

@vadmium vadmium

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@taleinat @vstinner @miss-islington @bedevere-bot @berkerpeksag @the-knights-who-say-ni