Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30737: Update link to the Devguide #3228

Merged
merged 3 commits into from Aug 30, 2017
Merged

bpo-30737: Update link to the Devguide #3228

merged 3 commits into from Aug 30, 2017
+22 −21

Conversation

@bugzPDX
Copy link
Contributor

bugzPDX commented Aug 28, 2017 •
edited by Mariatta

The Devguide has a new url so all the old links are updated.

https://bugs.python.org/issue30737
@bugzPDX bugzPDX force-pushed the bugzPDX:fix-devguide-url branch from e92577e to 94497ba Aug 28, 2017
@Mariatta
Mariatta requested changes Aug 28, 2017
View changes
Copy link
Member

Mariatta left a comment

Thanks for the PR @bugzPDX.

There is a merge conflict, so that has to be addressed.
Also, can drop the .html from new urls.
Doc/README.rst Outdated
@@ -7,7 +7,7 @@ available <https://docs.python.org/dev/download.html>`_.

Documentation on authoring Python documentation, including information about
both style and markup, is available in the "`Documenting Python
<https://docs.python.org/devguide/documenting.html>`_" chapter of the
<https://devguide.python.org/documenting.html>`_" chapter of the

This comment has been minimized.

Sign in to view
Copy link
@Mariatta

Mariatta Aug 28, 2017

Member

This can be dev.guide.python.org/documenting/ (without the .html)

This comment has been minimized.

Sign in to view
Copy link
@bugzPDX

bugzPDX Aug 28, 2017

Author Contributor

Will do
Doc/using/unix.rst Outdated
@@ -67,7 +67,7 @@ Building Python
If you want to compile CPython yourself, first thing you should do is get the
`source <https://www.python.org/downloads/source/>`_. You can download either the
latest release's source or just grab a fresh `clone
<https://docs.python.org/devguide/setup.html#getting-the-source-code>`_. (If you want
<https://devguide.python.org/setup.html#getting-the-source-code>`_. (If you want

This comment has been minimized.

Sign in to view
Copy link
@Mariatta

Mariatta Aug 28, 2017

Member

The url can be:
https://devguide.python.org/setup/#getting-the-source-code
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Aug 28, 2017

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@Mariatta Mariatta changed the title bpo-3037: Update link to the Devguide bpo-30737: Update link to the Devguide Aug 28, 2017
@Mariatta

This comment has been minimized.

Sign in to view
Copy link
Member

Mariatta commented Aug 28, 2017

I changed the bpo number to the correct one :)
@bugzPDX bugzPDX requested a review from gpshead as a code owner Aug 29, 2017
@bugzPDX bugzPDX requested a review from Aug 29, 2017
@gpshead

This comment has been minimized.

Sign in to view
Copy link
Member

gpshead commented Aug 30, 2017

Commits unrelated to this PR are showing up after your merge, I suspect you need to rebase to avoid that?
https://devguide.python.org/gitbootcamp/#syncing-with-upstream
bugzPDX added 3 commits Aug 28, 2017
@bugzPDX
bpo-3037: Update link to the Devguide
e5f806e 
The Devguide has a new url so all the old links are updated.
@bugzPDX
bpo-3073: Remove .html from urls. Update url to https
e4481ea 
Fix url endings by removing .html and update urls to use https.
@bugzPDX
bpo-30737: Fix whitespace issue
Loading status checks…
b96807c
@bugzPDX

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bugzPDX commented Aug 30, 2017

@bugzPDX bugzPDX force-pushed the bugzPDX:fix-devguide-url branch from 235776a to b96807c Aug 30, 2017
@Mariatta
Mariatta approved these changes Aug 30, 2017
View changes
@Mariatta

This comment has been minimized.

Sign in to view
Copy link
Member

Mariatta commented Aug 30, 2017

The changes look good now, and no longer showing diffs of unrelated commit.
@Mariatta Mariatta merged commit 384899d into python:master Aug 30, 2017
3 checks passed
3 checks passed
bedevere/issue-number Issue number 30737 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mariatta

This comment has been minimized.

Sign in to view
Copy link
Member

Mariatta commented Aug 30, 2017

Thanks @bugzPDX and congrats on your first contribution to CPython 🌮
jimmylai pushed a commit to jimmylai/cpython that referenced this pull request Sep 4, 2017
Jimmy Lai
Merge branch 'master' of https://github.com/python/cpython
923312f 
* 'master' of https://github.com/python/cpython: (601 commits)
  remove check for bug last seem in Solaris 9 (python#3285)
  Change code owners for hashlib and ssl to the crypto team (python#3284)
  bpo-31281: Fix pathlib.Path incompatibility in fileinput (pythongh-3208)
  remove autoconf check for select() (python#3283)
  remove configure check for 'volatile' (python#3281)
  Add missing _sha3 module to Setup.dist (python#2395)
  bpo-12383: Also ignore __PYVENV_LAUNCHER__ (python#3278)
  bpo-9146: add the missing NEWS entry. (python#3275)
  Fix a c.f.as_completed() refleak previously introduced in bpo-27144 (python#3270)
  bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (python#3076)
  remove a redundant lower in urllib.parse.urlsplit (python#3008)
  bpo-31323: Fix reference leak in test_ssl (python#3263)
  bpo-31250, test_asyncio: fix EventLoopTestsMixin.tearDown() (python#3264)
  bpo-31326: ProcessPoolExecutor waits for the call queue thread (python#3265)
  bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object (python#1560)
  bpo-31250, test_asyncio: fix dangling threads (python#3252)
  bpo-31217: Fix regrtest -R for small integer (python#3260)
  bpo-30096: Use ABC in abc reference examples (python#1220)
  bpo-30737: Update DevGuide links to new URL (pythonGH-3228)
  [Trivial] Remove now redundant assert (python#3245)
  ...
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Sep 6, 2017

🐍🍒⛏🤖 Thanks @bugzPDX for the PR, and @Mariatta for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 6, 2017
@bugzPDX @miss-islington
[3.6] bpo-30737: Update DevGuide links to new URL (pythonGH-3228)
73bffff 
Update old devguide links from https://docs.python.org/devguide to https://devguide.python.org
(cherry picked from commit 384899d)
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Sep 6, 2017

GH-3390 is a backport of this pull request to the 3.6 branch.
Mariatta added a commit that referenced this pull request Sep 6, 2017
@miss-islington @Mariatta
[3.6] bpo-30737: Update DevGuide links to new URL (GH-3228) (GH-3390)
Loading status checks…
98ceece 
Update old devguide links from https://docs.python.org/devguide to https://devguide.python.org
(cherry picked from commit 384899d)
GadgetSteve added a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
@bugzPDX @GadgetSteve
bpo-30737: Update DevGuide links to new URL (pythonGH-3228)
2a661f0 
Update old devguide links from https://docs.python.org/devguide to https://devguide.python.org
daxlab added a commit to daxlab/cpython that referenced this pull request Oct 1, 2017
@bugzPDX @daxlab
bpo-30737: Update DevGuide links to new URL (pythonGH-3228)
77c819e 
Update old devguide links from https://docs.python.org/devguide to https://devguide.python.org
@Mariatta Mariatta removed the awaiting merge label Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta

@gpshead gpshead

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@bugzPDX @bedevere-bot @Mariatta @gpshead @miss-islington @the-knights-who-say-ni
You can’t perform that action at this time.