Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-37404: Raising value error if an SSLSocket is passed to asyncio functions #16457
Conversation
This comment has been minimized.
This comment has been minimized.
Adding @taleinat as a reviewer |
This comment has been minimized.
This comment has been minimized.
I'm not very familiar with asyncio, but it seems to me that in these cases the code should raise an exception rather than emit a warning. A |
This comment has been minimized.
This comment has been minimized.
Agree with @taleinat, a |
This comment has been minimized.
This comment has been minimized.
Agree as well. |
This comment has been minimized.
This comment has been minimized.
Hi all, would fix it to throw a TypeError exception, I was following the thread in bpo - there was a discussion about sending a warning first instead of just throwing an exception without any notice first. Will commit a new version soon! |
This comment has been minimized.
This comment has been minimized.
Commited the new version: raising TypeError instead of a warning. |
This comment has been minimized.
This comment has been minimized.
@taleinat Maybe we can push this one as well? (been pending 2 months) |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 1, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This comment has been minimized.
This comment has been minimized.
Sorry for letting this languish, that's definitely on me! Thanks for the reminder. For this, we'll also need to add a NEWS entry. You can use blurb-it to do so easily in the browser, or install locally with |
LGTM |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 7, 2019
Sorry, I can't merge this PR. Reason: |
2 similar comments
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 7, 2019
Sorry, I can't merge this PR. Reason: |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 7, 2019
Sorry, I can't merge this PR. Reason: |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 7, 2019
Thanks @idomic for the PR |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 7, 2019
Sorry @idomic, I had trouble checking out the |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Dec 7, 2019
Sorry, I can't merge this PR. Reason: |
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 7, 2019
GH-17495 is a backport of this pull request to the 3.7 branch. |
…unctions (pythonGH-16457) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <michael.ido@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 7, 2019
GH-17496 is a backport of this pull request to the 3.8 branch. |
…ncio functions (pythonGH-16457) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <michael.ido@gmail.com>
…ncio functions (GH-16457) (#17496) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <michael.ido@gmail.com>
…unctions (GH-16457) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <michael.ido@gmail.com>
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 7, 2019
|
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Dec 7, 2019
|
idomic commentedSep 28, 2019
•
edited by miss-islington
https://bugs.python.org/issue37404
Automerge-Triggered-By: @asvetlov