bpo-38945: UU Encoding: Removed newline characters from uu encoding methods #17418

stealthcopter · 2019-11-30T09:15:09Z

@gvanrossum as discussed via email here is the PR for the uu encoding bug.

Sanitized filenames in UU encoding methods so that the filename cannot be overflowing in the UU encoded content area.

https://bugs.python.org/issue38945


        Removed newline characters from uu encoding methods

the-knights-who-say-ni · 2019-11-30T09:15:12Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@stealthcopter

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!


        Fixed trailing whitespace

isidentical

AFAIK This PR needs tests and a BPO issue

gvanrossum · 2019-11-30T16:36:09Z

It definitely,needs tests. It's been discussed privately, no bpo issue is needed.

gvanrossum · 2019-11-30T16:46:59Z

I take it back, it needs both a bpo issue and tests.

gvanrossum · 2019-11-30T16:49:57Z

This is a security issue and needs backports to all live versions. I expect that the 2.7 backport will need some manual help, as the code is superficially different there.


        Added test for uu encoding overflow

gvanrossum

LGTM. Waiting for CLA and news blurb.

@stealthcopter: Can you add a news blurb per instructions from the failing test? (If you can't let me know and I can see if I can remember how to do it.)


        📜🤖 Added by blurb_it.

gvanrossum · 2019-12-02T22:14:37Z

@stealthcopter Are you sure you submitted the CLA properly?

stealthcopter · 2019-12-02T22:22:39Z

@gvanrossum I just clicked on the 'check yourself' link and it looks like it kicked it into working :)

miss-islington · 2019-12-02T22:25:24Z

Thanks @stealthcopter for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot · 2019-12-02T22:25:24Z

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!


        bpo-38945: UU Encoding: Don't let newline in filename corrupt the out…

…put format (pythonGH-17418) (cherry picked from commit a62ad47) Co-authored-by: Matthew Rollings <1211162+stealthcopter@users.noreply.github.com>

bedevere-bot · 2019-12-02T22:25:37Z

GH-17442 is a backport of this pull request to the 3.8 branch.

bedevere-bot · 2019-12-02T22:25:43Z

GH-17443 is a backport of this pull request to the 3.7 branch.

gvanrossum · 2019-12-02T22:25:47Z

Thanks! I didn't even know that that feature existed. :-) Now on to the backports.

bedevere-bot · 2019-12-02T22:25:50Z

GH-17444 is a backport of this pull request to the 3.6 branch.

miss-islington · 2019-12-02T22:25:51Z

Sorry, @stealthcopter and @gvanrossum, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a62ad4730c9b575f140f24074656c0257c86a09a 2.7


        bpo-38945: UU Encoding: Don't let newline in filename corrupt the out…

…put format (pythonGH-17418) (cherry picked from commit a62ad47) Co-authored-by: Matthew Rollings <1211162+stealthcopter@users.noreply.github.com>


        bpo-38945: UU Encoding: Don't let newline in filename corrupt the out…

…put format (pythonGH-17418) (cherry picked from commit a62ad47) Co-authored-by: Matthew Rollings <1211162+stealthcopter@users.noreply.github.com>

gvanrossum · 2019-12-02T22:39:22Z

@stealthcopter Can you try the 2.7 backport? I think it's simple enough, there's an unrelated change on a nearby line.

stealthcopter · 2019-12-02T22:43:07Z

@gvanrossum yup no problem, I'll get this done tomorrow.


        bpo-38945: UU Encoding: Don't let newline in filename corrupt the out…

…put format (GH-17418) (cherry picked from commit a62ad47) Co-authored-by: Matthew Rollings <1211162+stealthcopter@users.noreply.github.com>


        bpo-38945: UU Encoding: Don't let newline in filename corrupt the out…

…put format (GH-17418) (cherry picked from commit a62ad47) Co-authored-by: Matthew Rollings <1211162+stealthcopter@users.noreply.github.com>


        bpo-38945: UU Encoding: Don't let newline in filename corrupt the out…

…put format (GH-17418) (GH-17444) (cherry picked from commit a62ad47) Co-authored-by: Matthew Rollings <1211162+stealthcopter@users.noreply.github.com>


        bpo-38945: UU Encoding: Don't let newline in filename corrupt the out…

…put format (pythonGH-17418) (pythonGH-17444) (cherry picked from commit a62ad47) Co-authored-by: Matthew Rollings <1211162+stealthcopter@users.noreply.github.com>


        [2.7] bpo-38945: UU Encoding: Don't let newline in filename corrupt t…

…he output format (pythonGH-17418). (cherry picked from commit a62ad47) Co-authored-by: Matthew Rollings <1211162+stealthcopter@users.noreply.github.com>

bedevere-bot · 2019-12-03T17:32:44Z

GH-17452 is a backport of this pull request to the 2.7 branch.

stealthcopter · 2019-12-03T17:36:47Z

Ok, think I've done it all now, sorry for the delay I had a bit of a battle with git.


        [2.7] bpo-38945: UU Encoding: Don't let newline in filename corrupt t…

…he output format (GH-17418). (#17452) (cherry picked from commit a62ad47) Co-authored-by: Matthew Rollings <1211162+stealthcopter@users.noreply.github.com>


        bpo-38945: UU Encoding: Don't let newline in filename corrupt the out…

…put format (python#17418)

Removed newline characters from uu encoding methods

Loading status checks…

47b888c

the-knights-who-say-ni added the CLA not signed label Nov 30, 2019

bedevere-bot added the awaiting review label Nov 30, 2019

Fixed trailing whitespace

Loading status checks…

b79021d

isidentical reviewed Nov 30, 2019

View changes

gvanrossum added needs backport to 3.6 needs backport to 2.7 needs backport to 3.7 needs backport to 3.8 labels Nov 30, 2019

stealthcopter changed the title ~~UU Encoding: Removed newline characters from uu encoding methods~~ bpo-38945: UU Encoding: Removed newline characters from uu encoding methods Dec 1, 2019

Added test for uu encoding overflow

Loading status checks…

5ad14ea

gvanrossum approved these changes Dec 1, 2019

View changes

bedevere-bot added awaiting merge and removed awaiting review labels Dec 1, 2019

📜🤖 Added by blurb_it.

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

86915af

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Dec 2, 2019

bedevere-bot removed the awaiting merge label Dec 2, 2019

bedevere-bot removed the needs backport to 3.8 label Dec 2, 2019

bedevere-bot removed the needs backport to 3.7 label Dec 2, 2019

bedevere-bot removed the needs backport to 3.6 label Dec 2, 2019

miss-islington assigned gvanrossum Dec 2, 2019

sthagen mentioned this pull request Dec 3, 2019

bpo-38945: UU Encoding: Don't let newline in filename corrupt the out… #62

Merged

bedevere-bot removed the needs backport to 2.7 label Dec 3, 2019

jacobneiltaylor added a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019

bpo-38945: UU Encoding: Don't let newline in filename corrupt the out…

2d66da5

…put format (python#17418)

python / cpython

bpo-38945: UU Encoding: Removed newline characters from uu encoding methods #17418

bpo-38945: UU Encoding: Removed newline characters from uu encoding methods #17418

stealthcopter commented Nov 30, 2019 •

edited by bedevere-bot

This comment has been minimized.

the-knights-who-say-ni commented Nov 30, 2019

isidentical left a comment

This comment has been minimized.

gvanrossum commented Nov 30, 2019 •

edited

This comment has been minimized.

gvanrossum commented Nov 30, 2019

This comment has been minimized.

gvanrossum commented Nov 30, 2019

gvanrossum left a comment

This comment has been minimized.

gvanrossum commented Dec 2, 2019

This comment has been minimized.

stealthcopter commented Dec 2, 2019

This comment has been minimized.

miss-islington commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

gvanrossum commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

miss-islington commented Dec 2, 2019

This comment has been minimized.

gvanrossum commented Dec 2, 2019

This comment has been minimized.

stealthcopter commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 3, 2019

This comment has been minimized.

stealthcopter commented Dec 3, 2019

python / cpython

Sponsor python/cpython

Join GitHub today

bpo-38945: UU Encoding: Removed newline characters from uu encoding methods #17418

bpo-38945: UU Encoding: Removed newline characters from uu encoding methods #17418

Conversation

stealthcopter commented Nov 30, 2019 • edited by bedevere-bot

This comment has been minimized.

the-knights-who-say-ni commented Nov 30, 2019

Recognized GitHub username

isidentical left a comment

This comment has been minimized.

gvanrossum commented Nov 30, 2019 • edited

This comment has been minimized.

gvanrossum commented Nov 30, 2019

This comment has been minimized.

gvanrossum commented Nov 30, 2019

gvanrossum left a comment

This comment has been minimized.

gvanrossum commented Dec 2, 2019

This comment has been minimized.

stealthcopter commented Dec 2, 2019

This comment has been minimized.

miss-islington commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

gvanrossum commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 2, 2019

This comment has been minimized.

miss-islington commented Dec 2, 2019

This comment has been minimized.

gvanrossum commented Dec 2, 2019

This comment has been minimized.

stealthcopter commented Dec 2, 2019

This comment has been minimized.

bedevere-bot commented Dec 3, 2019

This comment has been minimized.

stealthcopter commented Dec 3, 2019

stealthcopter commented Nov 30, 2019 •

edited by bedevere-bot

gvanrossum commented Nov 30, 2019 •

edited