Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-39377: json: Update doc about the encoding option. #18076
+9
−5
Conversation
I have a couple of minor grammar suggestions. Other than that, LGTM. |
.. versionchanged:: 3.6 | ||
*s* can now be of type :class:`bytes` or :class:`bytearray`. The | ||
input encoding should be UTF-8, UTF-16 or UTF-32. | ||
|
||
.. versionchanged:: 3.9 | ||
*encoding* keyword argument is removed. |
This comment has been minimized.
This comment has been minimized.
aeros
Jan 20, 2020
Member
Suggested change
*encoding* keyword argument is removed. | |
The keyword argument *encoding* has been removed. |
Python 3.1, it was deprecated and ignored. And using it was emitting | ||
:exc:`DeprecationWarning` since Python 3.8. |
Comment on lines
+430
to
+431
This comment has been minimized.
This comment has been minimized.
aeros
Jan 20, 2020
Member
Python 3.1, it was deprecated and ignored. As of Python 3.8, using it
emitted a :exc:`DeprecationWarning`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
methane commentedJan 20, 2020
•
edited by bedevere-bot
https://bugs.python.org/issue39377