Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39377: json: Update doc about the encoding option. #18076

Open
wants to merge 2 commits into
base: master
from

Conversation

@methane
Copy link
Member

methane commented Jan 20, 2020

Copy link
Member

aeros left a comment

I have a couple of minor grammar suggestions. Other than that, LGTM.

.. versionchanged:: 3.6
*s* can now be of type :class:`bytes` or :class:`bytearray`. The
input encoding should be UTF-8, UTF-16 or UTF-32.

.. versionchanged:: 3.9
*encoding* keyword argument is removed.

This comment has been minimized.

Copy link
@aeros

aeros Jan 20, 2020

Member
Suggested change
*encoding* keyword argument is removed.
The keyword argument *encoding* has been removed.
Python 3.1, it was deprecated and ignored. And using it was emitting
:exc:`DeprecationWarning` since Python 3.8.
Comment on lines +430 to +431

This comment has been minimized.

Copy link
@aeros

aeros Jan 20, 2020

Member
Python 3.1, it was deprecated and ignored. As of Python 3.8, using it
emitted a :exc:`DeprecationWarning`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.