Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPyLong_AsLongLong() docs should refer to 'long long' rather than 'long' #18082
+1
−1
Conversation
|
Thanks for the PR @keitherskine and welcome!
This PR is simple enough that we can skip the issue and news entry, that's typically the standard procedure for minor documentation fixes. The fix looks correct to me. I'll request a review @mdickinson though to be certain, since it looks like he made the last change to this section in f0acfee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
keitherskine commentedJan 20, 2020
In the docs for PyLong_AsLongLong(), it states that an Overflow exception will be raised if the value is out of range for a C-style
longinteger type. I believe this should refer tolong long, to align with the rest of the description of this function.The docs for the other functions in
Doc/c-api/long.rstappear to be correct.This seems like a trivial docs change, but if I need to raise a bug issue for it, do let me know.