Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the documentation of the LOAD_METHOD and CALL_METHOD bytecodes #18079

Merged
merged 1 commit into from Jan 21, 2020
Merged

improve the documentation of the LOAD_METHOD and CALL_METHOD bytecodes #18079

merged 1 commit into from Jan 21, 2020
+10 −8

Conversation

@cfbolz
Copy link
Contributor

cfbolz commented Jan 20, 2020

I was confused by the documentation of the LOAD_METHOD and CALL_METHOD bytecodes, so I tried to improve it. @methane, would you maybe have the time to take a look?
@cfbolz
improve the documentation of the LOAD_METHOD and CALL_METHOD bytecodes
Loading status checks…
d69e4cf
@csabella csabella requested a review from methane Jan 20, 2020
@aeros

This comment has been minimized.

Sign in to view
Copy link
Member

aeros commented Jan 20, 2020

Hmm, I think this is a small enough documentation enhancement that it doesn't require it's own issue and news entry, but feel free to remove it if needed.
@methane methane merged commit 8698b34 into python:master Jan 21, 2020
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20200120.13 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 21, 2020

Thanks @cfbolz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 21, 2020

Thanks @cfbolz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 21, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 21, 2020
@cfbolz @miss-islington
improve the documentation of the LOAD_METHOD and CALL_METHOD (pythonG…
61f9c5c 
…H-18079)

(cherry picked from commit 8698b34)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 21, 2020

GH-18091 is a backport of this pull request to the 3.7 branch.
miss-islington added a commit that referenced this pull request Jan 21, 2020
@miss-islington @cfbolz
improve the documentation of the LOAD_METHOD and CALL_METHOD (GH-18079)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d7b0118 
(cherry picked from commit 8698b34)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 21, 2020

Thanks @cfbolz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 21, 2020
@cfbolz @miss-islington
improve the documentation of the LOAD_METHOD and CALL_METHOD (pythonG…
01971da 
…H-18079)

(cherry picked from commit 8698b34)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Jan 21, 2020

GH-18092 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Jan 21, 2020
@miss-islington @cfbolz
improve the documentation of the LOAD_METHOD and CALL_METHOD (GH-18079)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
070e68a 
(cherry picked from commit 8698b34)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@cfbolz @petdance
improve the documentation of the LOAD_METHOD and CALL_METHOD (pythonG…
fb02230 
…H-18079)
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@cfbolz @petdance
improve the documentation of the LOAD_METHOD and CALL_METHOD (pythonG…
087d301 
…H-18079)
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@cfbolz @petdance
improve the documentation of the LOAD_METHOD and CALL_METHOD (pythonG…
da56b7a 
…H-18079)
petdance added a commit to petdance/cpython that referenced this pull request Jan 21, 2020
@cfbolz @petdance
improve the documentation of the LOAD_METHOD and CALL_METHOD (pythonG…
08d5395 
…H-18079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

Assignees
No one assigned
Labels
CLA signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@cfbolz @aeros @miss-islington @bedevere-bot @methane @the-knights-who-say-ni
You can’t perform that action at this time.