Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-38588: Optimize list comparison. #17766
Merged
+3
−0
Conversation
This comment has been minimized.
This comment has been minimized.
|
Edit: Sorry, I checked and it should not affect it. |
|
LGTM Thanks for the analysis and the quick fix Inada-san. And apologies for missing the comment in bpo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
methane commentedDec 31, 2019
•
edited by bedevere-bot
Mitigate performance regression of the list comparison caused by
2d5bf56.
https://bugs.python.org/issue38588