Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39377: json: Update doc about the encoding option. #18076

Open
wants to merge 5 commits into
base: master
from
Open

bpo-39377: json: Update doc about the encoding option. #18076

wants to merge 5 commits into from
+11 −8

Conversation

@methane
Copy link
Member

methane commented Jan 20, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue39377
@methane
bpo-39377: json: Update doc about the encoding option.
Loading status checks…
ec637b4
@methane methane added the skip news label Jan 20, 2020
@methane
Add What's New entry.
Loading status checks…
a9ae3d4
@aeros
aeros reviewed Jan 20, 2020
View changes
Copy link
Member

aeros left a comment

I have a couple of minor grammar suggestions. Other than that, LGTM.
Doc/library/json.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.9.rst Outdated
Python 3.1, it was deprecated and ignored. And using it was emitting
:exc:`DeprecationWarning` since Python 3.8.
Comment on lines 430 to 431

This comment has been minimized.

Sign in to view
Copy link
@aeros

aeros Jan 20, 2020

Member 
Python 3.1, it was deprecated and ignored. As of Python 3.8, using it
emitted a :exc:`DeprecationWarning`.

This comment has been minimized.

Sign in to view
Copy link
@methane

methane Jan 21, 2020

Author Member

I'm not good at English so I don't understand the difference between current sentence and your suggestion.
I just copied upper entry and edit. If I should change "using it was emitting..." to "using it emitted", shoud I change the upper entry too?

This comment has been minimized.

Sign in to view
Copy link
@ammaraskar

ammaraskar Jan 21, 2020

Member

Yeah, "emitted" is better since we're talking about a past version. Feel free to change was emitting -> emitted on the entry above as well.
@methane @aeros
Update Doc/library/json.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
49366db 
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
@ammaraskar

This comment has been minimized.

Sign in to view
Copy link
Member

ammaraskar commented Jan 21, 2020 •
edited

As Victor mentioned on the bpo issue, let's also note this in https://github.com/python/cpython/blob/master/Doc/whatsnew/3.9.rst#removed
@methane

This comment has been minimized.

Sign in to view
Copy link
Member Author

methane commented Jan 21, 2020

@ammaraskar Do you mean, I don't do it in this pull request?
Am I editing wrong place?
@ammaraskar

This comment has been minimized.

Sign in to view
Copy link
Member

ammaraskar commented Jan 21, 2020

Oh sorry, my mistake, it is in the right place.
@ammaraskar
ammaraskar approved these changes Jan 21, 2020
View changes
Copy link
Member

ammaraskar left a comment

LGTM with Kyle's suggestion.
methane added 2 commits Jan 21, 2020
@methane
Update 3.9.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e01c8fb
@methane
Update 3.9.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b3988c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammaraskar ammaraskar

@aeros aeros

Assignees
No one assigned
Labels
CLA signed awaiting core review skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@methane @ammaraskar @aeros @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.